Implemented rating resources function (Fixes #269) #270

yaoxing1990 · 2017-12-22T19:27:24Z

Implemented UI for user to submit rating:

yaoxing1990 · 2017-12-23T19:42:20Z

Implemented UI with comment. Added updating to database feature. Every time the same user gives a new rating, the old rating will be updated.

yaoxing1990 · 2017-12-23T22:57:50Z

I want to extract route parameter in ngOnInit but once I insert code into it, once restart, the app fails launching. Is there anything wrong with this? @paulbert @lmmrssa @nirojdyola

 this.route.paramMap.pipe(switchMap((params: ParamMap) => {
      this.getResource(params.get('id'));
      this.id = params.get('id');
    }))
 .subscribe(resource => this.resource = resource);

yaoxing1990 · 2017-12-24T23:37:09Z

@lmmrssa @paulbert Finished implementing resource rating feature (#269)
For example, 1 female gave 2.6 points, 1 male gave 4.8 points, so there are 2 people rating, the average point is (2.6 * 1 + 4.8 * 1) / 2 = 3.7, 3.7 * 20% = 74%

lmmrssa · 2017-12-25T01:58:22Z

@yaoxing1990 It seems you have added package-lock.json file, could you remove that? Also you have changed some of the package versions and added ts-lint on production. Please revert that as well.

This reverts commit 440fd72.

yaoxing1990 · 2017-12-25T02:29:11Z

@lmmrssa Reverted

razu9861 · 2017-12-25T04:14:18Z

package.json

@@ -58,7 +58,7 @@
 "protractor": "~5.1.2",
 "request-promise": "^4.2.1",
 "ts-node": "~3.2.0",
- "tslint": "~5.3.2",
+ "tslint": "^5.3.2",


why tslint is aded in package.json, its already been added you dont have to change it

@razu9861 I accidentally changed it form "~" to "^"

Yes, this change is not required for the given issue. The issue requires only rating function . So, you don;t have to change it. Could you revert it back ?

@nirojdyola Reverted

razu9861 · 2017-12-25T04:15:00Z

src/app/resources/rate-resources/resources-rate.component.ts

+})
+export class ResourcesRateComponent implements OnInit {
+
+ ratingForm: FormGroup;


please follow tslint rule for indentation

@razu9861 ole-vi@06a0b4b

nirojdyola · 2017-12-25T04:37:29Z

package.json

@@ -58,7 +58,7 @@
 "protractor": "~5.1.2",
 "request-promise": "^4.2.1",
 "ts-node": "~3.2.0",
- "tslint": "~5.3.2",
+ "tslint": "^5.3.2",


Yes, this change is not required for the given issue. The issue requires only rating function . So, you don;t have to change it. Could you revert it back ?

nirojdyola · 2017-12-25T04:37:50Z

src/app/resources/rate-resources/resources-rate.component.html

@@ -0,0 +1,45 @@
+<h1 i18n>Submit your rating</h1>
+<form [formGroup]="ratingForm" (ngSubmit)="onSubmit()">
+


Could you please remove extra line ?

nirojdyola · 2017-12-25T04:38:28Z

src/app/resources/rate-resources/resources-rate.component.html

+ <mat-error><planet-form-error-messages [control]="ratingForm.controls.id"></planet-form-error-messages></mat-error>
+ </mat-form-field>
+ </div>
+


Remove extra line please.

nirojdyola · 2017-12-25T04:38:56Z

src/app/resources/rate-resources/resources-rate.component.html

+ <mat-error><planet-form-error-messages [control]="ratingForm.controls.user"></planet-form-error-messages></mat-error>
+ </mat-form-field>
+ </div>
+


There are more extra line . Could you please remove all those ?

@nirojdyola All removed ole-vi@45ffaf3

nirojdyola · 2017-12-25T04:42:09Z

src/app/resources/resources.component.ts

@@ -10,7 +10,10 @@ export class ResourcesComponent implements OnInit, AfterViewInit {
 resources = new MatTableDataSource();
 @ViewChild(MatPaginator) paginator: MatPaginator;
 displayedColumns = [ 'title', 'rating' ];
- readonly dbName = 'resources';
+ readonly resourceDb = 'resources';


I don't understand why readonly dbName = 'resources'; has been changed to readonly resourceDb = 'resources';

Because another database named "rating" also exists, to avoid confusion

@nirojdyola

…to rating-resource

yaoxing1990 · 2017-12-25T16:36:49Z

@lmmrssa Because during registration, user gender is not recorded, so currently the gender cannot be obtained, Also the new database not in installation script is still a issue

lmmrssa · 2017-12-26T05:00:18Z

Error Received

 92% chunk asset optimization                                                 y <--- Last few GCs --->

  497502 ms: Mark-sweep 650.1 (1167.4) -> 449.3 (1143.4) MB, 3961.7 / 0.0 ms [allocation failure] [GC in old space requested].
  499260 ms: Mark-sweep 449.3 (1399.4) -> 449.1 (1343.4) MB, 1756.6 / 0.0 ms [allocation failure] [GC in old space requested].
  500839 ms: Mark-sweep 449.1 (1599.4) -> 446.9 (1450.4) MB, 1577.0 / 0.0 ms [last resort gc].
  502102 ms: Mark-sweep 446.9 (1450.4) -> 446.9 (1419.4) MB, 1262.9 / 0.0 ms [last resort gc].


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2e04a07cf781 <JS Object>
    1: flatten_args(aka flatten_args) [0x2e04a0704381 <undefined>:~11681] [pc=0xc7593c3eb59] (this=0x2e04a0704381 <undefined>,fn=0x358135d93731 <an AST_Function with map 0x112ae206ce79>,scope=0x358135d95499 <an AST_Function with map 0x196f7e2b9a59>)
    2: /* anonymous */(aka /* anonymous */) [0x2e04a0704381 <undefined>:11627] [pc=0xc7593dd885f] (this=0x2e04a0704381 <undefined>,self=0x2e2f9f6e0...

FATAL ERROR: Committing semi space failed. Allocation failed - process out of memory
 1: node::Abort() [ng]
 2: 0x109f13c [ng]
 3: v8::Utils::ReportApiFailure(char const*, char const*) [ng]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [ng]
 5: v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [ng]
 6: v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector, char const*, char const*, v8::GCCallbackFlags) [ng]
 7: v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [ng]
 8: v8::internal::Factory::NewStringFromOneByte(v8::internal::Vector<unsigned char const>, v8::internal::PretenureFlag) [ng]
 9: v8::internal::Factory::NumberToString(v8::internal::Handle<v8::internal::Object>, bool) [ng]
10: v8::internal::Object::ToString(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>) [ng]
11: v8::internal::Object::ConvertToName(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>) [ng]
12: v8::internal::LookupIterator::PropertyOrElement(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, bool*, v8::internal::LookupIterator::Configuration) [ng]
13: v8::internal::Runtime::GetObjectProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [ng]
14: 0xed4961 [ng]
15: v8::internal::Runtime_KeyedGetProperty(int, v8::internal::Object**, v8::internal::Isolate*) [ng]
16: 0xc758e8092a7
Aborted

paulbert · 2017-12-26T18:14:05Z

I had to force push a few updates because something strange happened where all of the previous commits on this PR were showing up as different from my local commits.

Before working on this you should delete your local branch (git branch -D rating-resource) then checkout again to get the branch on GitHub.

yaoxing1990 · 2017-12-26T18:16:45Z

@paulbert No problem. Is it caused by rebase? Laxman did rebase on this branch last night

paulbert · 2018-01-07T18:14:11Z

Travis failing because it's taking too long to build...

razu9861 · 2018-01-11T04:18:53Z

@yaoxing1990 i have attatched images for rating please implement this, have a look at both images add a button for rating on second image while clicking buton it should show popup for ratng. please try to implement it

paulbert · 2018-02-12T22:52:00Z

Closing since this was incorporated with #321

Implemented rating resources function (Fixes #269)

87eae0c

yaoxing1990 added the in progress label Dec 22, 2017

yaoxing1990 self-assigned this Dec 22, 2017

yaoxing1990 requested a review from paulbert December 22, 2017 19:31

yaoxing1990 added 3 commits December 22, 2017 16:30

Fix travis

d8bf8d2

Fix travis

e6bf6c7

Implemented UI and rating update feature

2f2b082

yaoxing1990 requested a review from lmmrssa December 23, 2017 19:42

yaoxing1990 added 4 commits December 23, 2017 19:10

Fix travis

dd6ec02

Fixed database update issue

6947ecf

Finished implementing rating resource

be21620

Change rating to float number

f4bbaf5

yaoxing1990 added 5 commits December 24, 2017 18:24

Fix travis and typo of f/m rating

715c9af

Fix travis

4bee29a

Fix travis

70fe8e9

Fix travis

547a1e7

Fix travis

440fd72

yaoxing1990 added 4 commits December 24, 2017 20:02

Revert "Fix travis"

e760caa

This reverts commit 440fd72.

Revert

f9d4898

Revert

d0bbe87

Remove unnecassary package.lock

c8ce111

razu9861 suggested changes Dec 25, 2017

View reviewed changes

Fix tslint

06a0b4b

nirojdyola requested changes Dec 25, 2017

View reviewed changes

Removed extra lines

45ffaf3

Merge branch 'rating-resource' of https://github.com/ole-vi/planet in…

8d63a5c

…to rating-resource

paulbert added 11 commits December 25, 2017 19:42

Add ratings to couchdb script and make db plural

b2144ff

Remove getResources, fix async addRating, simplify component properties

fb7090d

Add sort to findDocuments

5022816

Simplify resource rate template

37c7533

Add index to ratings db

74d129b

Add option to omit fields or sort from mangoQuery

8228021

Fix radio buttons and textarea

a858769

Update rating prop names

2288f71

Remove unnecessary imports and functions, add type

1af481c

Remove unnecessary imports, simplify & optimize resource/rating merge

b83930d

Lint fix

02be1b9

lmmrssa force-pushed the rating-resource branch from d36dcbe to f2b5ad5 Compare December 26, 2017 05:51

paulbert added 2 commits December 26, 2017 09:46

Merge with master by converting couchService to observables

fb354cc

Convert addRating to use observables

158a70b

paulbert force-pushed the rating-resource branch from f2b5ad5 to 158a70b Compare December 26, 2017 17:38

yaoxing1990 and others added 2 commits January 3, 2018 23:08

Merge branch 'master' into rating-resource

c993924

Fix build errors and remove extra lines

7807b2d

lmmrssa mentioned this pull request Jan 17, 2018

[#310] Resource List Rating Section Changes (connects #310) #315

Closed

nirojdyola added a commit that referenced this pull request Jan 26, 2018

[#310] combined #270 and #319

499ebbc

paulbert closed this Feb 12, 2018

paulbert removed the in progress label Feb 12, 2018

empeje deleted the rating-resource branch April 10, 2018 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented rating resources function (Fixes #269) #270

Implemented rating resources function (Fixes #269) #270

yaoxing1990 commented Dec 22, 2017

yaoxing1990 commented Dec 23, 2017

yaoxing1990 commented Dec 23, 2017

yaoxing1990 commented Dec 24, 2017

lmmrssa commented Dec 25, 2017

yaoxing1990 commented Dec 25, 2017

razu9861 Dec 25, 2017

yaoxing1990 Dec 25, 2017

nirojdyola Dec 25, 2017

yaoxing1990 Dec 25, 2017

razu9861 Dec 25, 2017

yaoxing1990 Dec 25, 2017

nirojdyola Dec 25, 2017

nirojdyola Dec 25, 2017

nirojdyola Dec 25, 2017

nirojdyola Dec 25, 2017

yaoxing1990 Dec 25, 2017

nirojdyola Dec 25, 2017

yaoxing1990 Dec 25, 2017

yaoxing1990 Dec 25, 2017

yaoxing1990 commented Dec 25, 2017

lmmrssa commented Dec 26, 2017

paulbert commented Dec 26, 2017

yaoxing1990 commented Dec 26, 2017

paulbert commented Jan 7, 2018

razu9861 commented Jan 11, 2018

paulbert commented Feb 12, 2018

		@@ -0,0 +1,45 @@
		<h1 i18n>Submit your rating</h1>
		<form [formGroup]="ratingForm" (ngSubmit)="onSubmit()">

Implemented rating resources function (Fixes #269) #270

Implemented rating resources function (Fixes #269) #270

Conversation

yaoxing1990 commented Dec 22, 2017

yaoxing1990 commented Dec 23, 2017

yaoxing1990 commented Dec 23, 2017

yaoxing1990 commented Dec 24, 2017

lmmrssa commented Dec 25, 2017

yaoxing1990 commented Dec 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaoxing1990 commented Dec 25, 2017

lmmrssa commented Dec 26, 2017

paulbert commented Dec 26, 2017

yaoxing1990 commented Dec 26, 2017

paulbert commented Jan 7, 2018

razu9861 commented Jan 11, 2018

paulbert commented Feb 12, 2018