[#4] Create Docker for Development #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empeje
changed the title
9 tasks
dogi
requested changes
Sep 8, 2017
There was a problem hiding this comment.
@mappuji very very awesome
can you change the file names to accommodate future file structure
docker
├── db-init
│ ├── Dockerfile
│ └── rpi-Dockerfile
├── planet
│ ├── Dockerfile
│ └── rpi-Dockerfile
├── planet-dev.yml
├── planet.yml
├── rpi-planet-dev.yml
└── rpi-planet.yml
empeje
commented
Sep 8, 2017
docker-dev/README.md
Outdated
| ## Description | ||
| This docker compose can be use for your development environment and very handy, you can spawn the development environment in a matter of seconds and start your development. Your code changes in host folder are automatically reflected to docker and ready to test in your browser. | ||
|
|
||
| ## How to use |
There was a problem hiding this comment.
Add how to use it
tells about docker logs
empeje
commented
Sep 9, 2017
docker-dev/docker-compose.yml
Outdated
| couchdb: | ||
| expose: | ||
| - 5984 | ||
| image: klaemo/couchdb |
There was a problem hiding this comment.
Better to use official docker image I think
dogi
requested changes
Sep 11, 2017
docker/planet/docker-entrypoint.sh
Outdated
| cd - | ||
| # End add CORS to CouchDB | ||
|
|
||
| # Add initial Couch databases here |
There was a problem hiding this comment.
remove trailing and following lines ;) thanks @mappuji
docker/db-init/docker-entrypoint.sh
Outdated
| git clone https://github.com/pouchdb/add-cors-to-couchdb.git | ||
| cd add-cors-to-couchdb | ||
| npm install | ||
| node bin.js http:https://couchdb:5984 |
docker/db-init/docker-entrypoint.sh
Outdated
| echo "..." | ||
| sleep 5 | ||
| WAIT_TIME=$(expr $WAIT_TIME + 5) | ||
| done |
There was a problem hiding this comment.
check if couchdb is already initialized
docker/planet/Dockerfile
Outdated
| VOLUME ["/$APP"] | ||
| WORKDIR /$APP | ||
|
|
||
| ADD ./docker-entrypoint.sh docker-entrypoint.sh |
dogi
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dogi and @paulbert we need to arrange a demo session for this one.
Basically in this PR I want to increase the development environment for faster development using docker and docker-compose. Checkout my PR and see readme for testing.
Solved #4