Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new label (fixes #2501) #2638

Merged
merged 13 commits into from
Dec 4, 2018
Merged

Add new label (fixes #2501) #2638

merged 13 commits into from
Dec 4, 2018

Conversation

paulbert
Copy link
Member

@paulbert paulbert commented Dec 4, 2018

Allows adding new labels from the dialog in the resource page.

Please test to make sure you can create a label and assign it to resources.

Next TODOs:

  • Adding a label which is a "sublabel" or attached to other labels doesn't do anything at this moment. Need to show this in the filter view.
  • Tags on the resource list show the id for a split second before changing to the text. Need to find ways to improve this.
  • A manager list view of labels where they can edit them after they have been created.

@lmmrssa
Copy link
Member

lmmrssa commented Dec 4, 2018

Creating new tag is not adding it to resource immediately. It closes the dialog as well so user has to click again to add tag.
Also adding tag to resource is adding ID of tag as shown in image below
screen shot 2018-12-04 at 18 26 21

@lmmrssa
Copy link
Member

lmmrssa commented Dec 4, 2018

Add label is not selecting old tags so when submitted it removes old tags if not selected.
screen shot 2018-12-04 at 18 30 36

@paulbert
Copy link
Member Author

paulbert commented Dec 4, 2018

@lmmrssa

  1. Yes that was another TODO that I forgot.
  2. Could you send some more info about the resource which does not have its old tags selected? On my machine all tags remain selected when opening the dialog.

@lmmrssa
Copy link
Member

lmmrssa commented Dec 4, 2018

Regarding point 2. It seems like label is added but it was the issue of checkbox not being selected that when you select and unselect checkbox it removes label and you wouldn't know have you removed any previous label or not as all previous label were not already checked.

Label already added
screen shot 2018-12-04 at 20 54 46
Add label popup without old label checked
screen shot 2018-12-04 at 20 58 39
Checking new label confusing as its not clear which labels are there in resource right now
screen shot 2018-12-04 at 20 54 36

@lmmrssa
Copy link
Member

lmmrssa commented Dec 4, 2018

Label auto selection is working now

@lmmrssa
Copy link
Member

lmmrssa commented Dec 4, 2018

not sure if it is only related to this branch or not but updated resource (video) does not load. Download of it works also it works with images. It works on master branch
screen shot 2018-12-05 at 00 10 12

@paulbert
Copy link
Member Author

paulbert commented Dec 4, 2018

@lmmrssa I don't think the video not showing is related as videos work locally for me. We can discuss at the meeting later.

@paulbert paulbert merged commit 91b17e5 into master Dec 4, 2018
@paulbert paulbert mentioned this pull request Dec 4, 2018
@lmmrssa lmmrssa deleted the 2501-add-new-label branch December 5, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants