Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen toggle (fixes #2420) #2466

Merged
merged 7 commits into from
Nov 15, 2018
Merged

Full screen toggle (fixes #2420) #2466

merged 7 commits into from
Nov 15, 2018

Conversation

svlesiv
Copy link
Member

@svlesiv svlesiv commented Nov 7, 2018

fixes #2420

Screenshots

screen shot 2018-11-06 at 9 43 32 pm

screen shot 2018-11-06 at 9 43 20 pm

screen shot 2018-11-06 at 9 43 45 pm

@i5o i5o added the in progress label Nov 7, 2018
@yubarajpoudel
Copy link
Contributor

Left margin should be reduced i guess
@paulbert @lmmrssa

screenshot 2018-11-07 13 21 33

margin-top: 10px;
margin-left: 70px;
padding-top: 30px;
padding-left: 80px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding left seems to be big. 10 px looks ok.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Probably I would need to add some media queries for that.

@lmmrssa
Copy link
Member

lmmrssa commented Nov 7, 2018

@svlesiv nice work, looks good. There are also other action next to it.
Toggle Preview Toggle Side by Side could you also test with these.

@svlesiv
Copy link
Member Author

svlesiv commented Nov 7, 2018

@lmmrssa thanks!)
I will try to fix Toggle Preview and Toggle Side by Side.

@svlesiv
Copy link
Member Author

svlesiv commented Nov 7, 2018

screen shot 2018-11-07 at 5 15 17 pm

screen shot 2018-11-07 at 5 15 35 pm

@svlesiv
Copy link
Member Author

svlesiv commented Nov 7, 2018

screen shot 2018-11-07 at 5 53 19 pm

screen shot 2018-11-07 at 5 53 55 pm

Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at how the fullscreen is implemented in the text-editor you should be able to fix this by just giving one of the containing elements position: relative;

That would be preferred to all of these small, hardcoded padding & position changes which are more difficult to maintain.

@paulbert
Copy link
Member

paulbert commented Nov 8, 2018

You can reference the way the component creators implemented it here:
https://teradata.github.io/covalent/#/components/text-editor

@svlesiv
Copy link
Member Author

svlesiv commented Nov 8, 2018

Hi @paulbert. Thanks for the link. I will take a look and try to implement that technic.

@paulbert
Copy link
Member

paulbert commented Nov 8, 2018

I looked at this a little more and found what does it: check out the text-editor-demo element in their implementation. It uses position: absolute to stretch the view to fill the screen and transform: translateY(0px) to set that as the containing element for the fixed position editor. Works with the two navigation layouts as is.

@svlesiv
Copy link
Member Author

svlesiv commented Nov 15, 2018

Thanks for your advice @paulbert. I looked on a demo. Seems like planet code doesn't generate classes for animation. Don't know why.

@svlesiv svlesiv changed the title Full screen toggle Full screen toggle (fixes #2420) Nov 15, 2018
@paulbert paulbert merged commit e63ccc6 into master Nov 15, 2018
@lmmrssa lmmrssa deleted the fullscreen-toggle branch November 15, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen on editor
5 participants