Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing .travis.yml #24

Merged
merged 15 commits into from
Sep 20, 2017
Merged

Testing .travis.yml #24

merged 15 commits into from
Sep 20, 2017

Conversation

daisywatson
Copy link
Contributor

No description provided.

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires changes.

sources:
- google-chrome
packages:
- google-chrome-stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use chrome, use phantom js, if we just confirm the functionalities.

http:https://karma-runner.github.io/0.8/plus/Travis-CI.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the tests are set up, they are using Chrome in headless mode so these are needed to run the tests.

notifications:
webhooks:
urls:
- https://webhooks.gitter.im/e/063276d3941fa8443947
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use private environment variable and hiding our notifications link. We don't want some people spamming our channel right? https://docs.travis-ci.com/user/environment-variables/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mappuji thanks I think we should open an extra/new issue for all our .travis.ymles ;)

/me thinks we have at least 4 ...

notifications:
webhooks:
urls:
- https://webhooks.gitter.im/e/063276d3941fa8443947
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mappuji thanks I think we should open an extra/new issue for all our .travis.ymles ;)

/me thinks we have at least 4 ...

Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to get Travis started. As the tests get completed, we can modify this as needed

@dogi dogi merged commit fbcbb65 into master Sep 20, 2017
@empeje empeje mentioned this pull request Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants