-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing .travis.yml #24
Conversation
* Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires changes.
sources: | ||
- google-chrome | ||
packages: | ||
- google-chrome-stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use chrome, use phantom js, if we just confirm the functionalities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the tests are set up, they are using Chrome in headless mode so these are needed to run the tests.
notifications: | ||
webhooks: | ||
urls: | ||
- https://webhooks.gitter.im/e/063276d3941fa8443947 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use private environment variable and hiding our notifications link. We don't want some people spamming our channel right? https://docs.travis-ci.com/user/environment-variables/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mappuji thanks I think we should open an extra/new issue for all our .travis.yml
es ;)
/me thinks we have at least 4 ...
notifications: | ||
webhooks: | ||
urls: | ||
- https://webhooks.gitter.im/e/063276d3941fa8443947 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mappuji thanks I think we should open an extra/new issue for all our .travis.yml
es ;)
/me thinks we have at least 4 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to get Travis started. As the tests get completed, we can modify this as needed
No description provided.