[#16] added attachment #22

nirojdyola · 2017-09-04T08:51:00Z

No description provided.

paulbert

In addition to the specific comments, the issue referenced specifically said we would address the attachments at a later time.

Please, if what you are working on doesn't match the issue create a new issue so the rest of the team can see what you are working on.

Also, I think we'll need to discuss how we will manage attachments:

Are we going to continue with the zip file solution for HTML resources or would another method be better?
Can we make any changes to the data structure to improve performance?

paulbert · 2017-09-04T14:46:21Z

src/app/home/navigation.scss

@@ -35,5 +35,9 @@
 li:last-child a {
 border:none;
 }
+


Please remove the change on the following lines. It is not related to creating the add resources component.

paulbert · 2017-09-04T14:50:35Z

src/app/resources/resources.component.ts

+
+ onChange(event) {
+ var files = event.target.files;
+ this.upload_files.push(


We are only supporting one file upload with the function as written, so there is no need to save this as an array. It just complicates the code below with constant [0]

paulbert · 2017-09-04T14:53:58Z

src/app/resources/resources.component.ts

+ var filename = this.upload_files[0].name;
+ var defaultOpts = {headers:headers,withCredentials:true};
+
+ this.couchService.post('/resources',{}).then(


Does it not work to post a resource with an attachment?

If possible, we should refactor this to only have one HTTP request.

paulbert · 2017-09-04T14:54:16Z

src/app/home/navigation.component.ts

@@ -7,7 +7,7 @@ import { Router } from '@angular/router';
 selector:'main-navigation',
 template: `
 <ul>
- <li *ngFor="let comp of components"><a [routerLink]="'/' + comp.link">{{comp.name.toUpperCase()}}</a></li>
+ <li *ngFor="let comp of components"><a routerLinkActive="active-link" [routerLink]="'/' + comp.link">{{comp.name.toUpperCase()}}</a></li>


Please remove this change. It is not related to creating the add resources component.

paulbert · 2017-09-04T14:56:35Z

src/app/shared/couchdb.service.ts

-
+
+ //For Attachment files
+ saveAttachment(db:string,data:any,content_type:any): Promise<any> {


This is an exact copy of the put method on the service. It is not necessary to add this, you can just use the put method.

In general, please do not add another method to the CouchService service. It is meant to be a quick wrapper for the basic HTTP requests to CouchDB.

Ah, I see the slight difference with the content_type parameter. Rather than mostly copy the put method, the opts parameter for the put method can be used to overwrite the header.

paulbert · 2017-09-04T15:00:37Z

src/app/resources/resources.component.html

+<div>
+ {{message}}
+ <ol>
+ <li *ngFor="let attachment of attachments">{{_.keys(attachment.doc._attachments)[0]}}</li>


This looks like the only place you are using Underscore. The resource list won't be listing out attachments, so I don't think we need to add an entire library for this one function that we will be removing in the future.

paulbert · 2017-09-04T15:01:13Z

.angular-cli.json

@@ -24,7 +24,8 @@
 ],
 "scripts": [
 "../node_modules/jquery/dist/jquery.min.js",
- "../node_modules/bootstrap/dist/js/bootstrap.min.js"
+ "../node_modules/bootstrap/dist/js/bootstrap.min.js",
+ "../node_modules/underscore/underscore-min.js" 


See the other comment. I don't think we need to add Underscore at this time.

paulbert · 2017-09-07T00:15:29Z

To make sure this keeps moving in the right direction, I went ahead and did some work on this today.

I added a resource view component which uses HTML5 tags for rendering audio, video, and PDFs. This way we can see how these browser players work with Angular.
Adding a resource is now done in one step, a PUT request with the file attachment included as a Base64 string within the JSON.
I added a basic file type dropdown to the resource add page which is used to tell the resource view component which player to use.
This means we no longer need the saveAttachments method. I'll reiterate that the methods on the CouchService all allow for changing the headers of the HTTP request. If you need to modify the headers you do not need to add a new function.
Also fully removed Underscore (it was still in the cli.json file and the package.json)
Removed the resources.scss. If we don't have custom css, no need for the file. We can always add it later.

I think that covers it.

nirojdyola · 2017-09-07T05:45:51Z

@paulbert I think we need to define the type of audio and video . Since , html5 doesn't support all type of audio and video.

paulbert · 2017-09-27T15:57:42Z

Merging this so we can continue working on resources, but I'll create an issue so we can continue the discussion about video & audio support for HTML5

[#16] added attachment

c7c4e02

nirojdyola requested review from lmmrssa, paulbert, dogi, Rupesh87, Pr0chin and razu9861 September 4, 2017 08:51

Pr0chin approved these changes Sep 4, 2017

View reviewed changes

paulbert requested changes Sep 4, 2017

View reviewed changes

nirojdyola and others added 10 commits September 5, 2017 14:25

[#16] removed underscore.js

890751f

Remove saveAttachments

311b114

Remove underscore

9520091

Remove activeLink

b741b7d

Remove empty declarations

0db404f

Fix Content-Type, remove unused modules, message is string

a0f47a2

Remove empty file

a22471a

Add new resource view route

e9c3fc9

Fix resource add & add basic file type dropdown

666d5ad

Add resource view

8f84070

paulbert approved these changes Sep 27, 2017

View reviewed changes

paulbert merged commit 78fc187 into master Sep 27, 2017

lmmrssa deleted the 16-Resources branch November 7, 2017 05:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#16] added attachment #22

[#16] added attachment #22

nirojdyola commented Sep 4, 2017

paulbert left a comment

paulbert Sep 4, 2017 •

edited

Loading

paulbert Sep 4, 2017

paulbert Sep 4, 2017

paulbert Sep 4, 2017

paulbert Sep 4, 2017

paulbert Sep 6, 2017 •

edited

Loading

paulbert Sep 4, 2017

paulbert Sep 4, 2017

paulbert commented Sep 7, 2017

nirojdyola commented Sep 7, 2017

paulbert commented Sep 27, 2017



		//For Attachment files
		saveAttachment(db:string,data:any,content_type:any): Promise<any> {

[#16] added attachment #22

[#16] added attachment #22

Conversation

nirojdyola commented Sep 4, 2017

paulbert left a comment

Choose a reason for hiding this comment

paulbert Sep 4, 2017 • edited Loading

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert Sep 4, 2017

Choose a reason for hiding this comment

paulbert commented Sep 7, 2017

nirojdyola commented Sep 7, 2017

paulbert commented Sep 27, 2017

paulbert Sep 4, 2017 •

edited

Loading

paulbert Sep 6, 2017 •

edited

Loading