[#19] Login redirect state url fixed #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirojdyola
requested review from
lmmrssa,
paulbert,
dogi,
Rupesh87,
Pr0chin and
razu9861
Pr0chin
approved these changes
Aug 31, 2017
paulbert
requested changes
Aug 31, 2017
src/app/login/login.component.ts
Outdated
| ) {} | ||
|
|
||
|
|
||
| ngOnInit() { |
There was a problem hiding this comment.
I don't think you actually should use ngOnInit here, just assign returnUrl to the route.
ngOnInit is used mainly for accessing the services to initialize data. returnUrl can be set with just simple assignment, so it doesn't need to utilize that lifecycle hook.
There was a problem hiding this comment.
Used returnUrl in constructor
|
You don't need to add it into the Constructor, either. Just add it as a normal property of the class. |
|
@nirojdyola See my latest commit. |
paulbert
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.