Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1640] dashboard overlapping text (connects #1640) #1705

Closed
wants to merge 3 commits into from

Conversation

singharpita
Copy link
Contributor

No description provided.

@lmmrssa
Copy link
Member

lmmrssa commented Jul 23, 2018

Looks good with the margin but found that whole tile gets affected by height of one item which is happening on master branch as well. So could you also fix it along with this PR.
sketch 79

@lmmrssa lmmrssa force-pushed the 1640-dashboard-overlapping-text branch from cc76a60 to 853c27b Compare July 24, 2018 02:24
@paulbert
Copy link
Member

Added some spacing for readability and changed how the height is set to preserve the vertical centering of the text.

After looking at this, I think there isn't a pure CSS solution. The text needs to be vertically centered when it doesn't overflow, but aligned to top when it does.

@lmmrssa lmmrssa force-pushed the 1640-dashboard-overlapping-text branch from 52b2210 to 603e076 Compare July 31, 2018 06:50
@lmmrssa
Copy link
Member

lmmrssa commented Jul 31, 2018

Text is still overlapped by remove icon
screen shot 2018-07-31 at 14 45 55

@lmmrssa
Copy link
Member

lmmrssa commented Jul 31, 2018

@dogi @paulbert changes made will add margin to top and center text based on remaining height. But it will still only show center part of the title. Couldn't find conditional styling that can be implemented based on content height.

Copy link
Member

@paulbert paulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmmrssa That last commit again messes up the vertical alignment of the text because it only adds margin-top.

Since there isn't a pure CSS solution, I think we should not bother modifying the span tag and handle the margin with JS

@lmmrssa lmmrssa force-pushed the 1640-dashboard-overlapping-text branch from 41dc32d to 603e076 Compare August 13, 2018 14:59
@lmmrssa
Copy link
Member

lmmrssa commented Aug 13, 2018

@paulbert reverted back the changes

@paulbert
Copy link
Member

Closing. This doesn't really improve upon the issue.

@paulbert paulbert closed this Oct 25, 2018
@lmmrssa lmmrssa deleted the 1640-dashboard-overlapping-text branch November 13, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants