new vagrant file #11
Closed
new vagrant file #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razu9861
requested review from
lmmrssa,
nirojdyola,
paulbert,
dogi,
Rupesh87 and
Pr0chin
paulbert
requested changes
Aug 23, 2017
| @@ -35,7 +35,7 @@ Vagrant.configure(2) do |config| | |||
| # config.vm.network "forwarded_port", guest: 80, host: 8082 | |||
| config.vm.network "forwarded_port", guest: 5984, host: 5984, auto_correct: true | |||
| config.vm.network "forwarded_port", guest: 5986, host: 5986, auto_correct: true | |||
| config.vm.network "forwarded_port", guest: 9000, host: 9000, auto_correct: true | |||
| config.vm.network "forwarded_port", guest: 3000, host: 3000, auto_correct: true | |||
There was a problem hiding this comment.
The master branch still serves the app on port 4200, so you will not be able to access the app on the host machine with this port forwarding.
| cd add-cors-to-couchdb | ||
| npm install | ||
| npm install -g @angular/cli | ||
| git clone https://github.com/ole-vi/planet.git |
There was a problem hiding this comment.
This and the next four lines are cloning and installing the repository a second time and unnecessary.
| # Run binding on each startup make sure the mount is available on VM restart | ||
| config.vm.provision "shell", run: "always", inline: <<-SHELL | ||
| docker start planet | ||
| # mount --bind /vagrant_node_modules /vagrant/node_modules |
There was a problem hiding this comment.
Why is this line commented out? This is used to reestablish node_modules folder binding on startup.
| cd planet | ||
| echo "install" | ||
| npm install | ||
| node bin.js http:https://localhost:5984 |
There was a problem hiding this comment.
This line is now thrown off because it is for the adding CORS to CouchDB portion and you are in the incorrect directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.