Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive Web App #105

Closed
wants to merge 43 commits into from
Closed

Progressive Web App #105

wants to merge 43 commits into from

Conversation

midsorbet
Copy link
Contributor

@midsorbet midsorbet commented Oct 20, 2017

Current Status

image

(related to #48)

Lighthouse Report

To Do:

  • Add @angular/service-worker and turn on service worker in .angular-cli.json
  • Add web manifest file
  • Indicate whether the user is working online or not
  • Add and use PouchDB

To test the PWA, you can clone the progressive-web-app branch and run ng build --prod. You need to serve the build over HTTP in your local machine for it to work. You can use serve to do so.

@midsorbet
Copy link
Contributor Author

midsorbet commented Nov 5, 2017

I keep getting a PouchDB is not a constructor(…) error. I tried following some solutions mentioned at pouchdb/pouchdb/issues/6692 but it did not work for me.

webpack-internal:https:///../../../core/@angular/core.es5.js:1220 ERROR Error: Uncaught (in promise): TypeError: PouchDB is not a constructor
TypeError: PouchDB is not a constructor
    at new CouchService (webpack-internal:https:///../../../../../src/app/shared/couchdb.service.ts:25)
    at _createClass (webpack-internal:https:///../../../core/@angular/core.es5.js:9729)
    at _createProviderInstance$1 (webpack-internal:https:///../../../core/@angular/core.es5.js:9703)
    at resolveNgModuleDep (webpack-internal:https:///../../../core/@angular/core.es5.js:9688)
    at _createClass (webpack-internal:https:///../../../core/@angular/core.es5.js:9733)
    at _createProviderInstance$1 (webpack-internal:https:///../../../core/@angular/core.es5.js:9703)
    at resolveNgModuleDep (webpack-internal:https:///../../../core/@angular/core.es5.js:9688)
    at NgModuleRef_.get (webpack-internal:https:///../../../core/@angular/core.es5.js:10762)
    at PreActivation.getToken (webpack-internal:https:///../../../router/@angular/router.es5.js:4647)
    at MapSubscriber.eval [as project] (webpack-internal:https:///../../../router/@angular/router.es5.js:4543)
    at new CouchService (webpack-internal:https:///../../../../../src/app/shared/couchdb.service.ts:25)
    at _createClass (webpack-internal:https:///../../../core/@angular/core.es5.js:9729)
    at _createProviderInstance$1 (webpack-internal:https:///../../../core/@angular/core.es5.js:9703)
    at resolveNgModuleDep (webpack-internal:https:///../../../core/@angular/core.es5.js:9688)
    at _createClass (webpack-internal:https:///../../../core/@angular/core.es5.js:9733)
    at _createProviderInstance$1 (webpack-internal:https:///../../../core/@angular/core.es5.js:9703)
    at resolveNgModuleDep (webpack-internal:https:///../../../core/@angular/core.es5.js:9688)
    at NgModuleRef_.get (webpack-internal:https:///../../../core/@angular/core.es5.js:10762)
    at PreActivation.getToken (webpack-internal:https:///../../../router/@angular/router.es5.js:4647)
    at MapSubscriber.eval [as project] (webpack-internal:https:///../../../router/@angular/router.es5.js:4543)
    at resolvePromise (webpack-internal:https:///../../../../zone.js/dist/zone.js:824)
    at resolvePromise (webpack-internal:https:///../../../../zone.js/dist/zone.js:795)
    at eval (webpack-internal:https:///../../../../zone.js/dist/zone.js:873)
    at ZoneDelegate.invokeTask (webpack-internal:https:///../../../../zone.js/dist/zone.js:425)
    at Object.onInvokeTask (webpack-internal:https:///../../../core/@angular/core.es5.js:4081)
    at ZoneDelegate.invokeTask (webpack-internal:https:///../../../../zone.js/dist/zone.js:424)
    at Zone.runTask (webpack-internal:https:///../../../../zone.js/dist/zone.js:192)
    at drainMicroTaskQueue (webpack-internal:https:///../../../../zone.js/dist/zone.js:602)
    at <anonymous>
defaultErrorLogger @ webpack-internal:https:///../../../core/@angular/core.es5.js:1220

yarn.lock Outdated
@@ -0,0 +1,6335 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

@lmmrssa lmmrssa mentioned this pull request Feb 6, 2018
@lmmrssa
Copy link
Member

lmmrssa commented Feb 6, 2018

closing this PR as it has been for long time and new PR has been started to work on this issue

@lmmrssa lmmrssa closed this Feb 6, 2018
@empeje empeje deleted the progressive-web-app branch April 10, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants