-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Integrate PouchDB #1025
[WIP] Integrate PouchDB #1025
Conversation
…ocs by createdDate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LKhadka A lot of the changes on here were stylistic rather than meaningful additions. Once or twice is fine, but with such a large change to our code base we can't effectively review changes when so many line changes do not change anything in the app. If you're having trouble with the code style, raise it as an issue so we can discuss adding a lint rule with PR.
Also, please install our pre push hook for tslint with npm run install-hooks
because some of those changes broke our lint rules.
} | ||
|
||
ngOnDestroy() { | ||
this.onDestroy$.next(); | ||
this.onDestroy$.complete(); | ||
this.onDestroy$.next(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onDestroy$ is no longer used with a subscription, and we should stick to next/complete for consistency when we use it.
…ocs by createdDate
Closing for new PR |
(related to #48)
What works?
If you want to test it please do the following:
Notes: