[#94] addnation (connects #94) #100

Pr0chin · 2017-10-18T09:46:18Z

No description provided.

lmmrssa · 2017-10-18T12:45:19Z

package.json

@@ -53,6 +53,7 @@
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "node-sass": "^4.5.3",
+    "popper.js": "^1.12.5",


this should not be in this issue

lmmrssa · 2017-10-18T12:45:32Z

src/app/home/home-router.module.ts

@@ -5,12 +5,15 @@ import { DashboardComponent } from '../dashboard/dashboard.component';
 import { UsersComponent } from '../users/users.component';
 import { HomeComponent } from './home.component';
 import { CoursesComponent } from '../courses/courses.component';
+import { NationComponent } from '../nation/nation.component';
+


looks like extra line

lmmrssa · 2017-10-18T12:46:38Z

src/app/home/home.module.ts

@@ -11,7 +11,8 @@ import { HomeRouterModule } from './home-router.module';
 import { CoursesComponent } from '../courses/courses.component';
 import { FormErrorMessagesComponent } from '../form-error-messages/form-error-messages.component';

-import { CourseValidatorService } from '../validators/course-validator.service';
+import { CourseValidatorService } from '../validators/course-validator.service';


why is this line showing as change

lmmrssa · 2017-10-18T12:47:23Z

src/app/nation/nation.component.html

+  <form class="form-horizontal"(ngSubmit)="onSubmit(nation.value)" #nation="ngForm">
+    <div class="form-group">
+      <label for="admin_name">Admin Name</label>
+      <input type="text" style="width:50%;" class="form-control" id="admin_name" required minlength="5" maxlength="30" [(ngModel)]="nation.admin_name" name="admin_name" #admin_name="ngModel">


better not to put inline style

lmmrssa · 2017-10-18T12:51:05Z

src/app/nation/nation.component.html

+      <label for="admin_name">Admin Name</label>
+      <input type="text" style="width:50%;" class="form-control" id="admin_name" required minlength="5" maxlength="30" [(ngModel)]="nation.admin_name" name="admin_name" #admin_name="ngModel">
+      <div *ngIf="admin_name.errors && (admin_name.dirty || admin_name.touched)" class="alert alert-danger" style="width:50%;">
+        <div [hidden]="!admin_name.errors.required">


It probably can be changed better way. @LKhadka had something that adds error message later based on validation

This needs to be changed into a reactive form so that you can use Angular's built in required validator. @Pr0chin can see an example here

@LKhadka 👍

paulbert · 2017-10-22T21:47:41Z

src/app/nation/nation.component.ts

+export class NationComponent implements OnInit {
+message = '';
+  constructor(
+  	private couchService: CouchService,


These should be indented to 4, not 3 spaces

@paulbert ok 👍

paulbert · 2017-10-22T21:48:11Z

src/app/nation/nation.component.ts

+  }
+  onSubmit(nation) {
+    if (nation.nation_name !== '' && nation.nationurl !== '' && nation.type !=="") {
+    console.log(nation.nation_name, nation.nationurl, nation.type);


Should be indented within the if block

paulbert

In addition to the other comments, please remove the package-lock.json file.

We need to make sure we use the same development environment with the same versions of node & npm. The package lock functionality was added with a newer version of npm than we began development with.

paulbert · 2017-10-24T00:21:12Z

package.json

@@ -7,12 +7,12 @@
    "start": "LNG=${LNG:-en};ng serve --aot --i18n-file=src/i18n/messages.$LNG.xlf --locale=$LNG --i18n-format=xlf",
    "v-serve": "vagrant ssh -c 'cd /vagrant;ng serve'",
    "build": "ng build",
-    "v-build":"vagrant ssh -c 'cd /vagrant;ng build'",
+    "v-build": "vagrant ssh -c 'cd /vagrant;ng build'",


Changes in this file are unrelated to the issue, so please remove them.

paulbert · 2017-10-24T00:23:56Z

src/app/nation/nation.component.html

+    <div class="form-group">
+      <label for="admin_name">Admin Name</label>
+      <input type="text" class="form-control" id="admin_name" required minlength="5" maxlength="30" [(ngModel)]="nation.admin_name" name="admin_name" #admin_name="ngModel">
+      <div *ngIf="admin_name.errors && (admin_name.dirty || admin_name.touched)" class="alert alert-danger" id = "danger">


The id referenced here is not unique, which is invalid HTML. Please use a class for this.

Also, the space around the equals should be removed.

paulbert · 2017-10-24T00:26:23Z

src/app/nation/nation.component.html

+     <div class="form-group">
+      <label for="nation_name">Name</label>
+      <input type="text" class="form-control" id="nation_name" required minlength="5" maxlength="30" [(ngModel)]="nation.nation_name" name="nation_name" #nation_name="ngModel">
+      <div *ngIf="nation_name.errors && (nation_name.dirty || nation_name.touched)" class="alert alert-danger"  id = "danger">


Fix id same as above

paulbert · 2017-10-24T00:26:38Z

src/app/nation/nation.component.html

+    <div class="form-group">
+      <label for="nation_name">Nationurl</label>
+      <input type="text" class="form-control" id="nationurl" required minlength="5" maxlength="30" [(ngModel)]="nation.nationurl" name="nationurl" #nationurl="ngModel">
+      <div *ngIf="nationurl.errors && (nationurl.dirty || nationurl.touched)" class="alert alert-danger" id = "danger">


Fix id same as above.

paulbert · 2017-10-24T00:26:46Z

src/app/nation/nation.component.html

+     <div class="form-group">
+      <label for="nation_name">Type</label>
+      <input type="text" class="form-control" id="type" required minlength="5" maxlength="30" [(ngModel)]="nation.type" name="type" #type="ngModel">
+      <div *ngIf="type.errors && (type.dirty || type.touched)" class="alert alert-danger" id = "danger">


Fix id same as above.

paulbert · 2017-10-24T00:36:12Z

src/app/nation/nation.component.scss

@@ -0,0 +1,15 @@
+#admin_name {


This is very repetitive, and more fitting as a class in the main styles.scss since this is reusable.

paulbert · 2017-10-24T00:38:49Z

src/app/nation/nation.component.ts

+        alert('Nation has been sucessfully created');
+        this.router.navigate(['']);
+      }, (error) => this.message = 'Error');
+    }else{


Please add spaces here to change it to } else {.

Before pushing code please make sure it runs through the linter either with the git hook or you can run it manually on your own.

* [#95]List of nation * [#95] Fetch Nation List * Update nation.component.ts * list nation * list nations

* [#96] added community commponent * [#96] Added filter * [#96] Added select option for status * [#96] css and indent fixed * [#96] Removed community.component.scss file

Pr0chin added 2 commits October 17, 2017 16:03

[#94] Add nation

53a3b7c

[#94] Validation added

b4736c6

Pr0chin requested review from lmmrssa, midsorbet, nirojdyola, paulbert, dogi, Rupesh87 and razu9861 October 18, 2017 09:46

Pr0chin added the in progress label Oct 18, 2017

lmmrssa requested changes Oct 18, 2017

View reviewed changes

paulbert reviewed Oct 22, 2017

View reviewed changes

[#94] Changes made

90d9bc0

paulbert requested changes Oct 24, 2017

View reviewed changes

dogi added the Hacktoberfest label Oct 24, 2017

paulbert mentioned this pull request Oct 24, 2017

96 list all communities of nations (connects #96) #111

Closed

[#94] Reactive form

e5054b1

Rupesh87 added the WIP label Oct 25, 2017

razu9861 and others added 5 commits October 25, 2017 11:37

db added

c87040e

95 list nation (#118)

30a41e7

* [#95]List of nation * [#95] Fetch Nation List * Update nation.component.ts * list nation * list nations

96 list all communities of nations (#117)

fe82b93

* [#96] added community commponent * [#96] Added filter * [#96] Added select option for status * [#96] css and indent fixed * [#96] Removed community.component.scss file

[#94] File extinction error

4331ba8

Merge branch 'testing' into 94-Addnation

7aeb264

lmmrssa closed this Oct 31, 2017

lmmrssa deleted the 94-Addnation branch November 7, 2017 05:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#94] addnation (connects #94) #100

[#94] addnation (connects #94) #100

Pr0chin commented Oct 18, 2017

lmmrssa Oct 18, 2017

Pr0chin Oct 23, 2017

lmmrssa Oct 18, 2017

lmmrssa Oct 18, 2017

lmmrssa Oct 18, 2017

lmmrssa Oct 18, 2017

midsorbet Oct 18, 2017 •

edited

Loading

Pr0chin Oct 23, 2017

paulbert Oct 22, 2017

Pr0chin Oct 23, 2017 •

edited

Loading

paulbert Oct 22, 2017

paulbert left a comment

paulbert Oct 24, 2017

paulbert Oct 24, 2017

paulbert Oct 24, 2017

paulbert Oct 24, 2017

paulbert Oct 24, 2017

paulbert Oct 24, 2017

paulbert Oct 24, 2017

[#94] addnation (connects #94) #100

[#94] addnation (connects #94) #100

Conversation

Pr0chin commented Oct 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

midsorbet Oct 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pr0chin Oct 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

midsorbet Oct 18, 2017 •

edited

Loading

Pr0chin Oct 23, 2017 •

edited

Loading