Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages/News posted by deleted members of the Community are shown on Teams/chat and on Community/News. #5945

Open
sjkadali opened this issue Mar 11, 2020 · 5 comments · May be fixed by #6328
Assignees

Comments

@sjkadali
Copy link
Member

Current Behavior

Messages/News posted by deleted members of the Community are shown on Teams/chat and on Community/News with reply options.

Screenshot from 2020-03-11 11-27-13

Screenshot from 2020-03-11 11-26-46

Desired Behavior

Messages/News posted by deleted members should not be shown or it should show members as deleted and with no reply options.

@paulbert
Copy link
Member

I think replies are fine, but an indication that the writer of the post is no longer a member of the community would be good.

@paulbert
Copy link
Member

@Haoran-Hu For this issue just an indication that the member is no longer a part of the community would be good.

Let's do name in italics with (no longer member) after the name

@paulbert
Copy link
Member

paulbert commented May 12, 2020

In NewsListComponent we should use requestUsers and usersListener from UsersService to get the list of all active users on the database.

We can add the message if the user planetCode matches this community and there is not a user in the list with a matching _id and joinDate (you can create a user with the same _id after that user is deleted).

@Haoran-Hu
Copy link
Member

@paulbert After I removed a member, that member is still on the database.

Haoran-Hu pushed a commit that referenced this issue May 16, 2020
Haoran-Hu pushed a commit that referenced this issue May 16, 2020
@Haoran-Hu Haoran-Hu linked a pull request May 16, 2020 that will close this issue
@Haoran-Hu
Copy link
Member

@paulbert I created a PR for this issue, it did not work, maybe it is because of the issue I stated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants