Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown editor: Invalid link silently breaks text #5583

Open
singharpita opened this issue Jan 21, 2020 · 2 comments
Open

Markdown editor: Invalid link silently breaks text #5583

singharpita opened this issue Jan 21, 2020 · 2 comments
Assignees

Comments

@singharpita
Copy link
Contributor

try to add any link and hit the submit button. but nothing is shown with console error
Screenshot from 2020-01-21 09-05-01
Screenshot from 2020-01-21 09-05-08

@singharpita singharpita changed the title Markeditor: Link is not working Markdown editor: Link is not working Jan 21, 2020
@paulbert paulbert changed the title Markdown editor: Link is not working Markdown editor: Invalid link silently breaks text Jan 21, 2020
@paulbert
Copy link
Member

This is an invalid markdown link. The text is in the brackets and link is in parentheses.

Regardless, this error should be handled better with the markdown rejected in the form rather than submitted to the database.

I only see the error when (http:https://) is submitted, but there may be other invalid urls.

@paulbert
Copy link
Member

It might be best to validate the markdown and throw an error that says "Please use valid link(s)".

The validation should match (http:https://) and any number of spaces between the parentheses and http:https://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants