Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full screen on editor #2420

Closed
lmmrssa opened this issue Oct 30, 2018 · 3 comments · Fixed by #2466
Closed

Full screen on editor #2420

lmmrssa opened this issue Oct 30, 2018 · 3 comments · Fixed by #2466
Assignees
@svlesiv

Comments

@lmmrssa
Copy link
Member

lmmrssa commented Oct 30, 2018

There is full screen mode on markdown editor which if confusing to use.
screen shot 2018-10-30 at 07 59 13
Button on image leads to look like this on next image. And its not clear how to return back. You have to press Esc key get back
screen shot 2018-10-30 at 07 59 32

So we might want to clean some of these action
@paulbert
Copy link
Member

This is the same issue as #2349 and #2255. Closing those

This was referenced Oct 30, 2018
Closed
Closed
Closed
@paulbert
Copy link
Member

Easiest fix is to remove full screen button until we find a better fix.

@svlesiv svlesiv self-assigned this Nov 5, 2018
svlesiv added a commit that referenced this issue Nov 5, 2018
@svlesiv
fix fullscreen overlap (fixes #2420)
42ccdb4
@svlesiv
Copy link
Member

svlesiv commented Nov 5, 2018 •
edited
Loading

I fixed full screen overlap and will be working on some alternative way of exiting full screen, or will remove the button.

screen shot 2018-11-05 at 6 22 14 pm

svlesiv added a commit that referenced this issue Nov 5, 2018
@svlesiv
fix fullscreen padding (fixes #2420)
f5960a1
svlesiv added a commit that referenced this issue Nov 7, 2018
@svlesiv
Add toolbar(fixes #2420)
ac751ca
@svlesiv svlesiv mentioned this issue Nov 7, 2018
Merged
@i5o i5o added the in progress label Nov 7, 2018
svlesiv added a commit that referenced this issue Nov 7, 2018
@svlesiv
fix toggle preview and toggle side by side (fixes #2420)
10fc54a
svlesiv added a commit that referenced this issue Nov 7, 2018
@svlesiv
add media queries (fixes #2420)
215f167
paulbert pushed a commit that referenced this issue Nov 15, 2018
@svlesiv @paulbert
Full screen toggle fit within navigation (fixes #2420) (#2466)
e63ccc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svlesiv svlesiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Full screen toggle (fixes #2420) open-learning-exchange/planet
4 participants
@i5o @lmmrssa @paulbert @svlesiv