Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default profile picture is not loading #1416

Closed
paulbert opened this issue Jun 21, 2018 · 6 comments
Closed

Default profile picture is not loading #1416

paulbert opened this issue Jun 21, 2018 · 6 comments

Comments

@paulbert
Copy link
Member

I think the picture is being bundled in /%three_letter_code%/assets/ now rather than just /assets/

image

@lmmrssa
Copy link
Member

lmmrssa commented Jun 21, 2018

All places we call assets we should not be putting relative path ../ or / that seems to fix it. This error only happens on production where we have multi language

@empeje
Copy link
Member

empeje commented Jun 21, 2018

I believe I already put the base-href to the respected language, is that not enough? Is there is any native-angular way to also add base-href to the assets?

@lmmrssa
Copy link
Member

lmmrssa commented Jun 22, 2018

@mappuji It is working when you put the url with language code while calling. But when you call it without any language code then it is just changing the url path but not redirecting looking at the asset from root path which is not working.

@empeje
Copy link
Member

empeje commented Jun 22, 2018

@lmmrssa from which layer we want to fix this? via angular or nginx?

seems @singharpita already trying to fix it with angular changes.

@lmmrssa
Copy link
Member

lmmrssa commented Jun 22, 2018

@mappuji we would like if you can fix it on nginx as well. But for now @singharpita tried to eliminate relative path as temporary solution

@empeje
Copy link
Member

empeje commented Jun 22, 2018

I think better to fix it on nginx since the problem introduced by nginx. Let the app as it is.

We can close @singharpita PR I guess, since I don't want to let her waste her time which better to spent on other issue 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants