Skip to content

Commit

Permalink
mylife: smoother achievement summary (fixes #7469) (#7470)
Browse files Browse the repository at this point in the history
Co-authored-by: dogi <[email protected]>
  • Loading branch information
Mutugiii and dogi committed May 29, 2024
1 parent a8290b1 commit aee1ae4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 31 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "planet",
"license": "AGPL-3.0",
"version": "0.14.36",
"version": "0.14.37",
"myplanet": {
"latest": "v0.15.47",
"min": "v0.14.47"
"latest": "v0.15.50",
"min": "v0.14.50"
},
"scripts": {
"ng": "ng",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@ export class UsersAchievementsUpdateComponent implements OnInit, OnDestroy {
if (formValue === undefined) {
return;
}
if (formValue.resources) {
formValue.resources.sort((a, b) => a.title.toLowerCase() > b.title.toLowerCase() ? 1 : -1);
}
this.updateFormArray(formArray, formGroup, index);
};
}
Expand Down Expand Up @@ -237,8 +234,4 @@ export class UsersAchievementsUpdateComponent implements OnInit, OnDestroy {
this.router.navigate([ '..' ], { relativeTo: this.route });
}

removeResource(achievement: FormControl, resource) {
achievement.setValue({ ...achievement.value, resources: achievement.value.resources.filter(({ _id }) => _id !== resource._id) });
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<span *ngIf="user?.firstName; else elseBlock">{{ user.firstName}} {{user.middleName}} {{user.lastName }}</span>
<ng-template #elseBlock>{{ user.name }}</ng-template>
<span class="toolbar-fill"></span>
<a mat-raised-button color="primary" style="margin-right: 1rem;" *ngIf="ownAchievements" (click)="generatePDF()">
<a mat-raised-button color="primary" style="margin-right: 1rem;" *ngIf="ownAchievements && !achievementNotFound" (click)="generatePDF()">
<span i18n>Print Achievements</span>
</a> <br>
<a mat-raised-button color="accent" routerLink="update" *ngIf="ownAchievements">
Expand Down
21 changes: 1 addition & 20 deletions src/app/users/users-achievements/users-achievements.service.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import { Injectable } from '@angular/core';
import { CouchService } from '../../shared/couchdb.service';
import { forkJoin } from 'rxjs';
import { map, first } from 'rxjs/operators';
import { ResourcesService } from '../../resources/resources.service';

@Injectable({
providedIn: 'root'
Expand All @@ -14,26 +11,10 @@ export class UsersAchievementsService {

constructor(
private couchService: CouchService,
private resourcesService: ResourcesService
) {}


getAchievements(id) {
this.resourcesService.requestResourcesUpdate(this.parent);
return forkJoin([
this.couchService.get(this.dbName + '/' + id),
this.resourcesService.resourcesListener(this.parent).pipe(first())
]).pipe(
map(([ userAchievements, resources ]: any[]) => {
const resourceIds = resources.map((res: any) => res._id);
userAchievements.achievements.forEach((achievement: any) => {
if (achievement.resources.length !== 0) {
achievement.resources = achievement.resources.filter(res => resourceIds.indexOf(res._id) !== -1);
}
});
return userAchievements;
})
);
return this.couchService.get(this.dbName + '/' + id);
}

isEmpty(achievement) {
Expand Down

0 comments on commit aee1ae4

Please sign in to comment.