This repository has been archived by the owner on Jun 11, 2018. It is now read-only.
Botocore instrumentation and improved requests coverage #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the build configurations have failed (Flask 0.10), but I don't think that failure is caused by any of the changes I've made. Do you have any idea what might be wrong? |
|
Hi @szilveszter First of all, thanks for your contribution, looks great! The test failure is indeed somewhat weird. For the Flask matrix test, Django (which causes the failure due to Django 1.10 not supporting Python 3.3) shouldn't be installed in the first place. It's being pulled in by django-celery. I'll have to refactor the requirements a bit to make sure this doesn't happen. I'll ping you here once that's done :) |
|
I updated the travis configuration. If you merge or rebase master, that error should go away :) |
szilveszter
force-pushed
the
botocore-instrumentation
branch
from
705feba
to
eabf968
Compare
|
@piquadrat thank you for the fix, now the tests are green :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds instrumentation for the AWS SDK (
boto3/botocore), and improves the coverage ofrequestsinstrumentation in order to pick upPreparedRequestssent directly on a lower level.This patch improved the coverage of our performance report significantly.