This repository has been archived by the owner on Jun 11, 2018. It is now read-only.
Django: use request.get_raw_uri to work around DisallowedHost #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django throws `DisallowedHost` when using `request.build_absolute_uri()`, where the host is not in the ALLOWED_HOSTS setting. This prevents Opbeat then from logging the event properly. Ref: https://code.djangoproject.com/ticket/27506
|
CI is broken, py.test fails:
|
timgraham
reviewed
Nov 23, 2016
| # Django 1.9. | ||
| get_raw_uri = request.get_raw_uri | ||
| except AttributeError: | ||
| # Requires host to be in ALLOWED_HOSTS. |
There was a problem hiding this comment.
To me, the "Django 1.9" comment isn't clear if that's for older versions or newer versions. I'd write:
except AttributeError: # Django ≤ 1.8
Of course, I'd also like to see a test that demonstrates the usefulness of the change, but I'm not an opbeat committer and so not familiar with their policies.
beniwohli
added a commit
that referenced
this pull request
Dec 20, 2016
Manually verified that the test fails with an exception without the patch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django throws
DisallowedHostwhen usingrequest.build_absolute_uri(), where the host is not in theALLOWED_HOSTS setting.
This prevents Opbeat then from logging the event properly.
Ref: https://code.djangoproject.com/ticket/27506