Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings modified and added test_5. #72

Closed
wants to merge 1 commit into from
Closed

Python bindings modified and added test_5. #72

wants to merge 1 commit into from

Conversation

stanislavsulc
Copy link
Contributor

No description provided.

@bpatzak
Copy link
Member

bpatzak commented Jan 8, 2020

HI,
I can not accept pull request as the tests on Travis have failed, for details see Travis log: https://travis-ci.org/oofem/oofem/builds/634154152?utm_source=github_status&utm_medium=notification
Additionally, there is an issue with FieldManager and its registerField method. The python interface should ensure that the lifetime of the field object passed as an argument corresponds to the lifetime of the FieldManager to prevent access errors when python field representation is garbage collected. Please use py::keep_alive directive.

@bpatzak bpatzak closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanislavsulc @bpatzak