Latticebond #62
Merged
Latticebond #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The old expressions didn't add up: matrice sizes for the first PK was a mismatch of voigt and matrix form. This means that there was no way the old code was working correctly. With the fixed size matrices, this became a compile error, and I tried to remedy it in a way that made sense.
…y are all defined). Also remove unnecessary dtor.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 39.78% 40.1% +0.32%
==========================================
Files 1241 1241
Lines 125299 125260 -39
==========================================
+ Hits 49849 50235 +386
+ Misses 75450 75025 -425
Continue to review full report at Codecov.
|
Micket
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition should only affect the lattice models.
I have