-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdpm2: parallel, thermal, damage compression #59
Conversation
Hi Peter, looks good, only one comment: is there any specific reason why you have replaced |
Hi Borek
The history variables in CDPM2 have originally size 6 in the status. However, I have in CDPM2 a giveRealStress_1D and giveRealStress_3D. For 1D, the strain is given as size 1. I then subtract the plastic strain, which has originally size 6 ... To avoid problem with that I write it as shown. (Alternatively, I could resize the plasticStrainVector once I have called it?)
Peter
…On Fri, 08 Nov 2019 16:06 +00:00, Borek Patzak ***@***.***> wrote:
Hi Peter, looks good, only one comment: is there any specific reason why you have replaced
`inelasticStrainVector.subtract(plasticStrainVector);`
by
`for ( int i = 1; i <= inelasticStrainVector.giveSize(); ++i ) { inelasticStrainVector.at(i) -= plasticStrainVector.at(i); } `
you made similar changes in different locations. I don't see much reason for this (except I overlooked one) and this just makes the generated code bigger.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=AH35S3TNP26BWM5YS63ZPYTQSWFADA5CNFSM4JKZORG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSR7UI#issuecomment-551886801>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH35S3TJO22RNZDSRHY2KM3QSWFADANCNFSM4JKZORGQ>.
|
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 39.6% 39.83% +0.22%
==========================================
Files 1241 1241
Lines 125538 125544 +6
==========================================
+ Hits 49720 50011 +291
+ Misses 75818 75533 -285
Continue to review full report at Codecov.
|
Hi Peter, |
Ok, I will change it.
Peter
…On Fri, 08 Nov 2019 16:28 +00:00, Borek Patzak ***@***.***> wrote:
Hi Peter,
ok. So what about creating the state variables with correct size from the beginning? The CreateStatus has gp as parameter, which knows its material mode, so the size of state vectors can be determined. See MPlasticMaterial2 and MPlasticMaterial2Status for an example.
Borek
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=AH35S3V4WSK7NGOLY6HNJZLQSWHS7A5CNFSM4JKZORG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSUD3I#issuecomment-551895533>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH35S3T5AL7FYQVDIPVFPUDQSWHS7ANCNFSM4JKZORGQ>.
|
Strange. On my system the code compiles without problems. Seems to be some unnecessary override's. |
OK, it seems to be fine now. I still get a warning concerning the initialisation of the plasticStrain and tempReducedStrain, which I do not understand. However, the tests pass. |
Changed cdpm2 to avoid problem with parallel computations.
Also introduced reduced strain so that thermal/shrinkage strains can be considered
Modified codes for tensile and compressive damage so that in the iterative approach the correct starting stress is considered.