Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lattice and periodic cell elements #57

Merged
merged 79 commits into from
Nov 7, 2019
Merged

Conversation

githubgrasp
Copy link
Contributor

Add lattice elements and materials.
Add periodic elements and vtkxml modules

adsci and others added 30 commits June 17, 2019 17:44
…in LTRSpaceBoundary element plus related tests
@bpatzak
Copy link
Member

bpatzak commented Nov 6, 2019

Hi Peter,
can you resolve conflicts before I can accept the pull request.

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #57 into master will increase coverage by 1.31%.
The diff coverage is 57.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   38.04%   39.36%   +1.31%     
==========================================
  Files        1177     1241      +64     
  Lines      120133   125772    +5639     
==========================================
+ Hits        45707    49508    +3801     
- Misses      74426    76264    +1838
Impacted Files Coverage Δ
src/tm/Elements/lattice2d_mt.h 38.46% <ø> (ø) ⬆️
...lements/LatticeElements/latticestructuralelement.C 100% <ø> (ø)
src/sm/CrossSections/fiberedcs.h 25% <ø> (+16.66%) ⬆️
bindings/python/oofem.cpp 75.91% <ø> (ø) ⬆️
src/tm/Materials/latticetransmat.C 81.53% <ø> (ø) ⬆️
src/oofemlib/vtkxmlexportmodule.h 77.27% <ø> (ø) ⬆️
src/sm/Elements/Interfaces/intelpoint.h 64.7% <ø> (ø) ⬆️
src/sm/Materials/structuralmaterial.h 14.28% <ø> (-1.1%) ⬇️
src/oofemlib/interpolatingfunction.h 0% <ø> (ø) ⬆️
src/sm/Contact/ActiveBc/node2nodepenaltycontact.h 0% <ø> (ø) ⬆️
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17636...3ca3ec6. Read the comment docs.

@githubgrasp
Copy link
Contributor Author

Hi Borek
I have resolved the conflicts now.
Peter

@bpatzak
Copy link
Member

bpatzak commented Nov 6, 2019

Hi Peter,
There are four test failing:
The following tests FAILED:
115 - test_sm_lattice_damageviscoelastic_01.in (SEGFAULT)
116 - test_sm_lattice_damageviscoelastic_02.in (SEGFAULT)
117 - test_sm_lattice_plastdamviscoel_01.in (Failed)
118 - test_sm_lattice_plastdamviscoel_02.in (Failed)
Errors while running CTest

Also I can see a lot of warning during compilation of lattice elements. Would be nice to fix them before merging. I understand that warnings are due to recent changes, I can fix them by myself, but fix the tests, please.
Borek

@githubgrasp
Copy link
Contributor Author

githubgrasp commented Nov 6, 2019 via email

@bpatzak bpatzak merged commit 93f95f3 into oofem:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants