Dingtalk notify optimization: complete docs & add escape (megaease#191)

* docs: add dingtalk notify secret * fix: escape to prevent possible parse failure
onyas · Aug 10, 2022 · 62ea263 · 62ea263
1 parent 504c529
commit 62ea263
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -221,6 +221,7 @@ notify:
  dingtalk:
  - name: "dingtalk alert service"
  webhook: "https://oapi.dingtalk.com/robot/send?access_token=xxxx"
+ secret: "" # sign secret if set
  lark:
  - name: "lark alert service"
  webhook: "https://open.feishu.cn/open-apis/bot/v2/hook/d5366199-xxxx-xxxx-bd81-a57d1dd95de4"

diff --git a/notify/dingtalk/dingtalk.go b/notify/dingtalk/dingtalk.go
@@ -66,7 +66,7 @@ func (c *NotifyConfig) SendDingtalkNotification(title, msg string) error {
  "text": "%s"
  }
  }
- `, title, msg)
+ `, report.JSONEscape(title), report.JSONEscape(msg))
  req, err := http.NewRequest(http.MethodPost, addSign(c.WebhookURL, c.SignSecret), bytes.NewBuffer([]byte(msgContent)))
  if err != nil {
  return err