Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2436 #2447

Merged
merged 18 commits into from
Feb 25, 2020
Merged

Fix issue #2436 #2447

merged 18 commits into from
Feb 25, 2020

Conversation

daquexian
Copy link
Member

No description provided.

@daquexian daquexian requested a review from a team as a code owner November 12, 2019 10:15
@daquexian daquexian mentioned this pull request Nov 12, 2019
Closed
@daquexian
Copy link
Member Author

@houseroad Is this PR ok to merge? Thanks!

@daquexian
Copy link
Member Author

@houseroad Any comments? Thanks!

@daquexian
Copy link
Member Author

@houseroad @linkerzhang Is this PR ok to merge? Thanks!

@daquexian
Copy link
Member Author

@houseroad @linkerzhang I have fixed the flake8 error. The CI error is not related to this PR

@daquexian
Copy link
Member Author

@linkerzhang @houseroad Is it ok to merge this PR? Thanks!

@daquexian
Copy link
Member Author

The appveyor CI error is not related to this PR

@daquexian daquexian closed this Feb 14, 2020
@daquexian daquexian reopened this Feb 14, 2020
@daquexian
Copy link
Member Author

@linkerzhang @houseroad Is it ok to merge this PR? Thanks!

@prasanthpul prasanthpul added this to the 1.7 milestone Feb 24, 2020
@linkerzhang linkerzhang merged commit 2e67bfc into onnx:master Feb 25, 2020
@daquexian daquexian deleted the fix_2436 branch February 26, 2020 01:59
@daquexian daquexian mentioned this pull request Feb 26, 2020
Closed
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
@daquexian @linkerzhang @prasanthpul
Fix issue onnx#2436 (onnx#2447)
ef464cd 
* Fix issue onnx#2436

* Add clarification

* Add test

* Fix flake8 error

Co-authored-by: Ke Zhang <[email protected]>
Co-authored-by: Prasanth Pulavarthi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkerzhang linkerzhang linkerzhang approved these changes

@houseroad houseroad Awaiting requested review from houseroad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@daquexian @linkerzhang @houseroad @prasanthpul