Fixed aliases for images and fixed broken preloader #13
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onmotion
reviewed
Oct 3, 2019
| @@ -152,6 +152,7 @@ | |||
| }); | |||
|
|
|||
| inputField.on('fileunlock', function(event, data, previewId, index) { | |||
| inputField.fileinput('upload'); | |||
There was a problem hiding this comment.
The fileunlock event is triggered when the upload process is completed (successfully or with error). Why do we need to call upload?
There was a problem hiding this comment.
It does not upload at all.
All that happens on my side is it reloads - without a POST.
When I call the upload function - it uploads with no errors.
According to the documentation - this is only triggered after an upload - I understood this wrong. However - its not uploading at all.
https://plugins.krajee.com/file-input/plugin-events#fileunlock
Please allow me a few minutes to fix this.
There was a problem hiding this comment.
Also - the preloader just loads into infinity.
If I use JQuery - it works like a charm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no Alias specified - for the people who use localhost as their dev environment - the current code didnt work. I implemented a fix specifically for this.
Also - the native Javascript was broken and changed it to use JQuery instead. This way is works as you wanted it to. :)