New parameters for Hoeffding Tree Classifiers #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the near future, I might refactor the split criteria classes. They deserve some love :D |
MaxHalford
approved these changes
Jun 14, 2023
|
Yeap, they are too Java-styled and can be streamlined for sure! On a side note, the failing tests seem to be unrelated to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1169.
I added the
max_share_to_splitparameter, as discussed in the issue. Besides that, I also exposed another parameter that was inherited from MOA. This one prevents splitting when most of the data is concentrated in a single branch (regardless of the class distribution).