Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: sycl: pooling: Reduce argument size #1951

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

sgeor255
Copy link
Contributor

@sgeor255 sgeor255 commented Jun 7, 2024

Description

Please include a summary of the change. Please also include relevant motivation and context. See contribution guidelines for more details. If the change fixes an issue not documented in the project's Github issue tracker, please document all steps necessary to reproduce it.

Fixes # (github issue)

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@vpirogov vpirogov added this to the v3.6 milestone Jun 12, 2024
@vpirogov
Copy link
Member

make test

@vpirogov
Copy link
Member

make test

@sgeor255, please disregard this. Just using your PR as a guinea pig for our validation system.

@srazumov
Copy link
Contributor

make test

@vpirogov vpirogov added platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels Jun 28, 2024
Copy link
Contributor

@dzarukin dzarukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to have someone from your team to review the code as well.

@mgouicem mgouicem merged commit d65aae2 into oneapi-src:main Jul 12, 2024
8 of 10 checks passed
@vpirogov vpirogov added platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic and removed platform:gpu-nvidia Codeowner: @oneapi-src/onednn-gpu-nvidia platform:gpu-amd Codeowner: @oneapi-src/onednn-gpu-amd labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants