Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] [RISC-V] add compatible headers for new version of rvv intrinsics #1856

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BHbean
Copy link

@BHbean BHbean commented Apr 2, 2024

Description

I have been trying to cross-compile openvino for RISC-V target with rv64gcv arch recently, and I found an issue related to compatiblity of rvv intrinsics. See this issue for detailed information.

Fixes the following github issue
openvinotoolkit/openvino#23784

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@vpirogov vpirogov added this to the v3.5 milestone Apr 2, 2024
@@ -17,7 +17,7 @@

#include "rvv_nchw_pooling.hpp"
#include <algorithm>
#include <riscv_vector.h>
#include "intrin_rvv.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "intrin_rvv.h"
#include "cpu/rv64/intrin_rvv.hpp"

@@ -0,0 +1,16 @@
// Referenced from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright banner?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply! Could you plz tell me how to resolve the copyright issues?

#include "intrin_rvv_011_compat.h"
#endif

#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End-of-File symbol is missing.

@vpirogov
Copy link
Member

vpirogov commented Apr 18, 2024

The fact that this patch includes 30K LOCs of copy pasted code is a bit intimidating. I would suggest updating intrinsics in pooling implementation to RVV intrinsics v0.11 or even better stable RVV intrinsics v0.12. Compiler support is documented here.

@BHbean
Copy link
Author

BHbean commented Apr 20, 2024

The fact that this patch includes 30K LOCs of copy pasted code is a bit intimidating. I would suggest updating intrinsics in pooling implementation to RVV intrinsics v0.11 or even better stable RVV intrinsics v0.12. Compiler support is documented here.

Thanks for your reply! I will try to update the intrinsics to the latest stable version! :)

@vpirogov vpirogov modified the milestones: v3.5, v3.6 May 21, 2024
@vpirogov vpirogov removed this from the v3.6 milestone Sep 19, 2024
@vpirogov vpirogov requested a review from a team as a code owner November 1, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants