Skip to content

Commit

Permalink
Render keynav help off-screen and slide it in (honestbleeps#4706)
Browse files Browse the repository at this point in the history
* added container function for keyNav toggling

* slide in pre-rendered keynav help

* refined slide nimation for keynav help
  • Loading branch information
jeromew21 authored and erikdesjardins committed Mar 23, 2018
1 parent 59ae3e9 commit 89e4d75
Showing 1 changed file with 21 additions and 1 deletion.
22 changes: 21 additions & 1 deletion lib/modules/keyboardNav.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ module.options = {
value: [191, false, false, true, false], // ? (note the true in the shift slot)
description: 'keyboardNavToggleHelpDesc',
title: 'keyboardNavToggleHelpTitle',
callback() { drawHelp().toggle(300); },
callback() { toggleKeyNavHelp(); },
},
toggleCmdLine: {
type: 'keycode',
Expand Down Expand Up @@ -885,6 +885,26 @@ function updateLinkAnnotations(selected) {
});
}

function toggleKeyNavHelp() {
const slideSpeed = 400;
if (!drawHelp().attr('shown')) {
drawHelp().attr('shown', 'false');
drawHelp().css({ right: '-350px' });
drawHelp().show();
}
if (drawHelp().attr('shown') === 'true') {
drawHelp().animate({
right: '-350px',
}, slideSpeed);
drawHelp().attr('shown', 'false');
} else {
drawHelp().animate({
right: '20px',
}, slideSpeed);
drawHelp().attr('shown', 'true');
}
}

const drawHelp = _.once(() => {
const keys = filterMap(getActiveCommandOptions(), opt => {
let keyCode = niceKeyCode(opt.value);
Expand Down

0 comments on commit 89e4d75

Please sign in to comment.