Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing offset-*-0 #1584

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Fixing missing offset-*-0 #1584

merged 1 commit into from
Jul 9, 2020

Conversation

Erdou
Copy link
Contributor

@Erdou Erdou commented Jul 9, 2020

This fixes the missing offset-*-0 (and other components) required when wanting to revert on bigger screen size
Issue #1583

This fixes the missing offset-*-0 (and other components) required when wanting to revert on bigger screen size
@Erdou
Copy link
Contributor Author

Erdou commented Jul 9, 2020

Pull request created in 4.3.10 as requested

@olton olton merged commit d1f22ee into olton:4.3.10 Jul 9, 2020
@Erdou Erdou deleted the patch-2 branch July 9, 2020 19:16
olton added a commit that referenced this pull request Jul 9, 2020
@olton
Copy link
Owner

olton commented Jul 9, 2020

I extend your PR for non media offset

@Erdou
Copy link
Contributor Author

Erdou commented Jul 9, 2020

I extend your PR for non media offset

I thought about that, but didn't do it because you won't need something like offset-0, as it's already zero offset for nothing.
But why not for consistency.

olton added a commit that referenced this pull request Oct 28, 2023
Fixing missing offset-*-0
olton added a commit that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants