Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min latency should be lowest measured non 0 #23

Closed
olle opened this issue May 16, 2020 · 1 comment · Fixed by #25
Closed

Min latency should be lowest measured non 0 #23

olle opened this issue May 16, 2020 · 1 comment · Fixed by #25
Assignees
@olle
Labels
bug Something isn't working
Milestone
0.9

Comments

@olle
Copy link
Owner

olle commented May 16, 2020

The latency metrics should either be fixed, in case there is a bug, or tuned. Actually a min and max latency is really only interesting as a moving, or windowed, measurement.

First step would at least be to check why it tends towards 0, and synthetically disallow it.
@olle olle added this to the 0.9 milestone May 16, 2020
@olle olle added the bug Something isn't working label May 16, 2020
@olle olle self-assigned this May 25, 2020
@olle
Copy link
Owner Author

olle commented May 25, 2020

Meh!

olle added a commit that referenced this issue May 25, 2020
@olle
Filter non measurable latencies
eaf19e2 
* Ensures that stats without a sensible measured min/max latency
  value, are filtered. Avoiding the use of synthetic 0 latency
  measurements - which taints the min-metric.

* fixes #23
@olle olle mentioned this issue May 25, 2020
Merged
@olle olle closed this as completed in #25 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olle olle

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

Filter non measurable latencies olle/query-response-spring-amqp
1 participant
@olle