Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non LegacyDummyDirAlgorithm creates C:\ProgramFilesFolder empty folder #1223

Closed
11v1 opened this issue Oct 21, 2022 · 7 comments
Closed

Non LegacyDummyDirAlgorithm creates C:\ProgramFilesFolder empty folder #1223

11v1 opened this issue Oct 21, 2022 · 7 comments
Labels
bug Done / Released

Comments

@11v1
Copy link

11v1 commented Oct 21, 2022

Hi,

If I have an installer without files by default C:\ProgramFilesFolder is created. With LegacyDummyDirAlgorithm = true there is no empty folder. It looks like something went wrong with the non-legacy algorithm.
@oleg-shilo
Copy link
Owner

Thank you Grigorii,
Can you please share your simple setup definition that exhibits the problem?

I have checked and Registry sample after commenting out the files does create c:\ProgramFilesFolder
image

Maybe you can check if in your environment this sample behaves the same way as in mine?

@11v1
Copy link
Author

11v1 commented Oct 24, 2022

Hi Oleg,

With the Registry sample, I have the same issue, if I remove the code you highlighted then C:\ProgramFilesFolder folder is created during installation. If I write AutoElements.LegacyDummyDirAlgorithm = true then msi works as expected and no folder is created.

@oleg-shilo
Copy link
Owner

Hm-m-m, it's not what I observe with that very sample.
Let me recheck again, in case something went wrong with the test.

But if you are right then nothing much we can do about it. No support for no-directory scenario is a WiX/MSI limitation and it just means that today only one version of WixSharp workaround works - AutoElements.LegacyDummyDirAlgorithm = true. So I will need to hardcode it to true.

I will let you know my findings.

@oleg-shilo
Copy link
Owner

I can confirm that you were right and the new algorithm does leave dummy folder in the drive root (the old algorithm does it in the program files).
But I actually found a workaround that allows avoid ing this problem.

Will let you know when it is ready

oleg-shilo added a commit that referenced this issue Oct 28, 2022
@oleg-shilo
- Issue #1223: Non LegacyDummyDirAlgorithm creates C:\ProgramFilesFol…
0290ed6 
…der empty folder
@oleg-shilo
Copy link
Owner

Done, will be available in the very next release

@11v1
Copy link
Author

11v1 commented Oct 31, 2022

I'm happy to hear that. Thank you, Oleg.

oleg-shilo added a commit that referenced this issue Jan 6, 2023
@oleg-shilo
Release v1.20.3.0
053fef6 
- Issue #1244: The directory Id generated can be too long
- Issue #1223: Non LegacyDummyDirAlgorithm creates C:\ProgramFilesFolder empty folder
- Issue #1220: ElevatedManagedAction issue
- Feature #1204: Feature - RegisterCom class to ease the registration of COM files
- Issue #1203: SilentBootstrapperApplication
- Issue #182 (extended solution): RegistrySearch has "Win64=no" when building x64 installers
- Added Self-executable_Msi sample
- Added WixBootstrapper_EmbeddedUI to demonstrate how to show managed UI if the bundled MSI
- Added sample for customization of the stock Burn UI. Triggered by #1219
- Added sample for "Issue #1218: Dynamic custom UI sequence"
- Resurrected setting user input from BA UI and passing it to the msi. RegistrySearch input is also retained.
- Added validation for `Issue #1075: [FEAT] Add error if LaunchApplicationFromExitDialog using in common Project` error.
- Fixed problem with RegKey being placed in the x86 root XML dir for the x64 project
@oleg-shilo
Copy link
Owner

Done.
https://github.com/oleg-shilo/wixsharp/releases/tag/v1.20.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Done / Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oleg-shilo @11v1