Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring api fga #1510

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Spring api fga #1510

wants to merge 19 commits into from

Conversation

indiepopart
Copy link
Contributor

This blog post has the following features:

  • A GitHub Repository with a polished README
  • A GitHub Repository under the github.com/oktadev account
  • A title that's approved by Dev Advocacy
  • A URL approved by Dev Advocacy
  • The content has been run through Grammarly (https://www.grammarly.com/)
  • Rendered locally and confirmed that no Markdown typos exist
  • Images are compressed appropriately
  • Social image previews well on Twitter and LinkedIn
  • Tech review request (developer advocate or domain expert)
  • Review request for editorial/grammar/clarity (developer advocate or Colton)

Copy link

netlify bot commented May 10, 2024

Deploy Preview for okta-blog ready!

Name Link
🔨 Latest commit 9addf9b
🔍 Latest deploy log https://app.netlify.com/sites/okta-blog/deploys/6659fc1dbbfcf30008160202
😎 Deploy Preview https://deploy-preview-1510--okta-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sambego
Copy link

Sambego commented May 10, 2024

@deepu105 can you go over the Java code, you're better suited to review that :)

Copy link
Contributor

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java bits looks fine, some minor comments here and there. I'll leave the FGA bits and overall blog structure to @Sambego

_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-spring-api-fga.md Outdated Show resolved Hide resolved
@jimmyjames
Copy link

Overall this looks good to me!

@indiepopart
Copy link
Contributor Author

@deepu105 @Sambego I updated for most of the comments. Still 2 conversations open. Back to you!

@Sambego
Copy link

Sambego commented Jun 3, 2024

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants