Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express universal logout #1504

Merged
merged 31 commits into from
Apr 30, 2024
Merged

Express universal logout #1504

merged 31 commits into from
Apr 30, 2024

Conversation

isemona
Copy link
Contributor

@isemona isemona commented Apr 30, 2024 •
edited
Loading

This blog post has the following features:

  • A GitHub Repository with a polished README
  • A GitHub Repository under the github.com/oktadev account
  • A title that's approved by Dev Advocacy
  • A URL approved by Dev Advocacy
  • The content has been run through Grammarly (https://www.grammarly.com/)
  • Rendered locally and confirmed that no Markdown typos exist
  • Images are compressed appropriately
  • Social image previews well on Twitter and LinkedIn
  • Tech review request (developer advocate or domain expert)
  • Review request for editorial/grammar/clarity (developer advocate or Colton)

@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for okta-blog ready!

Name Link
🔨 Latest commit 1e3cba6
🔍 Latest deploy log https://app.netlify.com/sites/okta-blog/deploys/6631744a8168980008379a8a
😎 Deploy Preview https://deploy-preview-1504--okta-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

edunham
edunham approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@edunham edunham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions -- feel free to reject any except fixing the workshop link on line 24. That one actually matters :)

alisaduncan
alisaduncan reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and suggestions

_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
danielmaharry-okta
danielmaharry-okta approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@danielmaharry-okta danielmaharry-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Semona, Just a few changes. Mostly it's fixing cntractions and using sign in / out instead of log in/out where it's not a product name.

_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
_source/_posts/2024-04-30-express-universal-logout.md Outdated Show resolved Hide resolved
isemona and others added 11 commits April 30, 2024 11:28
@isemona @alisaduncan
Update _source/_posts/2024-04-30-express-universal-logout.md
6c950d5 
Co-authored-by: Alisa <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
a379a93 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
4017092 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
92e7792 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
51697b8 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
601e3da 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
6e9984c 
Co-authored-by: Dan Maharry <[email protected]>
@isemona
Update 2024-04-30-express-universal-logout.md
0bcb391
@isemona
Merge pull request #2 from isemona/isemona-patch-1
c1f269b 
Update 2024-04-30-express-universal-logout.md
@isemona @danielmaharry-okta
Update _source/_posts/2024-04-30-express-universal-logout.md
7392e76 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta @alisaduncan
Apply suggestions from code review
1cfa651 
Co-authored-by: Dan Maharry <[email protected]>
Co-authored-by: Alisa <[email protected]>
isemona and others added 11 commits April 30, 2024 13:01
@isemona @alisaduncan @danielmaharry-okta
Apply suggestions from code review
6201aa5 
Co-authored-by: Alisa <[email protected]>
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Apply suggestions from code review
2c26be0 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta @alisaduncan
Apply suggestions from code review
54e35d9 
Co-authored-by: Dan Maharry <[email protected]>
Co-authored-by: Alisa <[email protected]>
@isemona @alisaduncan
Apply suggestions from code review
d7eba89 
Co-authored-by: Alisa <[email protected]>
@isemona @danielmaharry-okta
Apply suggestions from code review
c44d572 
Co-authored-by: Dan Maharry <[email protected]>
@isemona @danielmaharry-okta
Apply suggestions from code review
8521b37 
Co-authored-by: Dan Maharry <[email protected]>
@isemona
Update 2024-04-30-express-universal-logout.md
acb98c9
@isemona
Update 2024-04-30-express-universal-logout.md
a4a3db8
@isemona
Update 2024-04-30-express-universal-logout.md
0846d26
@isemona
Update 2024-04-30-express-universal-logout.md
b47a44f
@isemona
Update 2024-04-30-express-universal-logout.md
1e3cba6
@isemona isemona merged commit 9ac57b3 into oktadev:main Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisaduncan alisaduncan alisaduncan left review comments

@edunham edunham edunham approved these changes

@danielmaharry-okta danielmaharry-okta danielmaharry-okta approved these changes

@palermo4 palermo4 Awaiting requested review from palermo4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@isemona @edunham @alisaduncan @danielmaharry-okta