Fix 'awscli logout' command #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +136,7 @@ command="$1" | |||
| profile=$2 | |||
| shift; | |||
| shift; | |||
| if [ "$3" == "logout" ] | |||
| if [ "$1" == "logout" ] | |||
There was a problem hiding this comment.
Can you explain how you are calling withokta. I don't understand why we even need to check why $1 or $3 (though I do agree $3 in this case is incorrect and will reference an empty string).
If you just call:
withokta logout profile command will already be logout
There was a problem hiding this comment.
I'm using the awscli command. When I execute awscli logout 'awscli' wrapper script run withokta aws default logout and in this moment the withokta script doesn't work as expected.
There was a problem hiding this comment.
I updated the PR name and description. Now, they are more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
You cannot logout from your AWS account using 'awscli logout' command.
Solution
Fix the argument management on 'withokta' script