🐛 Only remove --profile arg when in OKTA_ENV_MODE #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- With #303, the call to `removeProfileArguments` moved out of only OKTA_ENV_MODE. I don't think this is correct since it was specifically added in #185 which added OKTA_ENV_MODE. - I have also added support for removing `--profile=*` arguments as well since that is also a valid use of the `aws` CLI.
|
@jeremyplichtafc it looks like you recently made a new release of this project. Would you mind taking a look at this PR and also #324? |
jeremyplichtafc
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
removeProfileArgumentsmoved out of only OKTA_ENV_MODE. I don't think this is correct since it was specifically added in 🌱 Add support for EnvVars integration #185 which added OKTA_ENV_MODE.Solution
removeProfileArgumentsback to only the OKTA_ENV_MODE execution path.--profile=*arguments as well since that is also a valid use of theawsCLI.