Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser auth issue, multiple roles, and make role to assume more flexible #318

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

jeremyplichtafc
Copy link
Collaborator

Problem Statement

  • The javafx window remains open and never shuts down once user authenticates (Java opens console instead of reverting to shell #317)
  • Multiple roles are not handles correctly due to order of roleArn and principal being incorrect in map (this reverts previous change ecbf26e#diff-13509f60aa8d183ec80dc2582dc38e74R49)
  • I would like more flexibility for the OKTA_AWS_ROLE_TO_ASSUME env variable to be a full arn or just a name since in my scenario we are wrapping this tool and supporting multiple accounts and roles

Solution

  • check for relative path in form /saml
  • fix order of role arn map
  • modify code that selects role to check OKTA_AWS_ROLE_TO_ASSUME match on role arn or role name

- check for relative /saml path so javafx window closes
- make OKTA_AWS_ROLE_TO_ASSUME more flexible so it matches on full arn
or role name
@jeremyplichtafc
Copy link
Collaborator Author

@mraible or @AlainODea - can one of you take a look at this and let me know if it can be merged? This fixes #317 which is preventing the current version of this project working for anyone that uses web browser authentication. Thanks!

@AlainODea AlainODea merged commit 4534684 into oktadev:master Jun 21, 2019
@AlainODea
Copy link
Contributor

Thank you for your contribution, @jeremyplichtacfc. I have not been maintaining this project, but this is a straight-forward, good change and I didn’t want it to sit unmerged.

@jeremyplichtafc
Copy link
Collaborator Author

Thanks @AlainODea for coming out of ofka-aws-cli retirement temporarily to merge this 😄
Is @mraible the only one that can cut a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants