Config file update fix #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed check on role_arn value being blank or not since this interferes with the default profile update (which might not need a role_arn value in the ~/.aws/config file). This parameter will not be updated if blank in the WriteNewRoleToAssume function anyway.
|
lgtm 🚀 |
AlainODea
pushed a commit
to AlainODea/okta-aws-cli-assume-role
that referenced
this pull request
Jun 3, 2018
* Config file update fix Removed check on role_arn value being blank or not since this interferes with the default profile update (which might not need a role_arn value in the ~/.aws/config file). This parameter will not be updated if blank in the WriteNewRoleToAssume function anyway. * Added cross account role debug log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed check on role_arn value being blank or not since this interferes with the default profile update (which might not need a role_arn value in the ~/.aws/config file).
This parameter will not be updated if blank in the WriteNewRoleToAssume function anyway.
Also fixed code formatting using IntelliJ built-in Reformat Code menu.
@ibabiy-okta, do you think you could review this tiny update? Thanks :)