Support for role array in AWS managed policies #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibabiy-okta
reviewed
Dec 12, 2016
| System.out.println("\nYou entered an invalid number. Please try again."); | ||
| return SelectRole(lstRoles); | ||
| } | ||
| else { |
There was a problem hiding this comment.
nit: you don't need else clause here, because you have return in if
|
@raphaellondner-okta, since you requested to take a look only at the AWS logic part, I won't comment other stuff. 👍 |
Removed unnecessary else statement
|
Thanks @ibabiy-okta for the feedback. I have removed the unnecessary else statement in the latest commit. |
|
🚢 |
AlainODea
pushed a commit
to AlainODea/okta-aws-cli-assume-role
that referenced
this pull request
Jun 3, 2018
* Support for role array in managed policies * Code syntax fix Removed unnecessary else statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.