Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Correctly handle nested configs #183

Merged
merged 3 commits into from
Aug 21, 2018
Merged

🐛 Correctly handle nested configs #183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f90ac
:bug: Correctly handle nested configs
AlainODea Aug 19, 2018
c3170bb
:art: Address @frosforever's code review
AlainODea Aug 21, 2018
785d642
:art: Address @frosforever's code review
AlainODea Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
🐛 Correctly handle nested configs 
Apologies for the extensiveness of this change. The configuration
handling likely needs a refactor to make it easier to support future
modification.

 - Add Apache Commons Configuration2

 - Adapt configuration2's INIConfiguration to support AWS quirks

 - Remove Ini4j (unmaintained, has park page for website)

 - Refactor file handling code

Resolves #141
  • Loading branch information
@AlainODea
AlainODea committed Aug 19, 2018
commit 87f90ac171ae3888d6681bc2b5c0781433353a34
17 changes: 12 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@
<artifactId>json</artifactId>
<version>${json.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-configuration2</artifactId>
<version>2.3</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
Expand All @@ -85,11 +90,6 @@
<artifactId>log4j-core</artifactId>
<version>${log4j.version}</version>
</dependency>
<dependency>
<groupId>org.ini4j</groupId>
<artifactId>ini4j</artifactId>
<version>${ini4j.version}</version>
</dependency>
<dependency>
<groupId>org.jsoup</groupId>
<artifactId>jsoup</artifactId>
Expand Down Expand Up @@ -138,6 +138,13 @@
<version>1.0.0</version>
<scope>test</scope>
</dependency>
<!-- Dynamic dependency of commons-configuration -->
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>1.9.3</version>
<scope>runtime</scope>
</dependency>
</dependencies>

<distributionManagement>
Expand Down
Loading