Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Closing browser auth doesn't quit #179

Merged
merged 1 commit into from
Aug 21, 2018
Merged

🐛 Closing browser auth doesn't quit #179

merged 1 commit into from
Aug 21, 2018

Conversation

AlainODea
Copy link
Contributor

Problem Statement

Manually closing the browser auth window with the embedded browser doesn't quit the program. It stays running in a stuck/broken state.

Solution

  • Clicking close exits the application with code 1

Resolves #163

@AlainODea
🐛 Closing browser auth doesn't quit
e5ed6ad 
 - Clicking close exits the application with code 1

Resolves oktadev#163
@AlainODea
Copy link
Contributor Author

@loopingz my #167 PR of this change got torched when the history cleanup ran. Can you re-review this?

@AlainODea AlainODea merged commit 6bca36a into oktadev:master Aug 21, 2018
@AlainODea AlainODea deleted the ao-BUG-closing-browser-wont-quit branch September 29, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loopingz loopingz loopingz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing browser auth window doesn't quit
2 participants
@AlainODea @loopingz