Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fill in config.properties documentation #112

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

AlainODea
Copy link
Contributor

Problem Statement

Some properties in config.properties aren't documented.

Solution

Add documentation for OKTA_PROFILE and OKTA_BROWSER_AUTH.

 - Document OKTA_PROFILE

 - Document OKTA_BROWSER_AUTH
@AlainODea
Copy link
Contributor Author

@slancio do these docs make sense to you? I was inspired by your change to catch up on docs I forgot to add.

@slancio
Copy link
Contributor

slancio commented Apr 19, 2018

The docs make sense but I'm confused about OKTA_PROFILE. I'm using an old version that I distributed to my engineers and the profile names are in the format aws_account/aws_role/okta_username(company_email)_source. Does this "random profile name" change that was implemented change that behavior?

@AlainODea
Copy link
Contributor Author

@slancio good point. Random isn’t really the word. It’s more accurate to say they’re generated.

OKTA_PROFILE is intended to support external tools like Terraform where you need a specifically named profile instead of a generated profile name.

It also allows this tool to be used with boto3 or other downstream AWS SDKs that can use named profiles. I’ve personally used it with Java, Python, PowerShell, and Haskell programs in this way.

@slancio
Copy link
Contributor

slancio commented Apr 19, 2018

We use terraform with this a lot and the advice that we give is to either set the AWS_PROFILE/AWS_DEFAULT_PROFILE envvars to the generated profile name (because that name does not change), use the terraform aws iam profile resource, or specify the profile name in the terraform aws provider.

As long as the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY envvars are clear, the envvar suggestion should work in any language using the standard libraries for working with AWS.

@AlainODea
Copy link
Contributor Author

Neat! I didn’t know that. I’ve been so focused on the Okta side of this, that I haven’t dug into Terraform much yet. I didn’t realize it had —profile switch support on the CLI!

@slancio
Copy link
Contributor

slancio commented Apr 20, 2018

Sorry, i mispoke about profile switch support (i thought it did) hence the edit. envvar and in terraform config only.

@slancio
Copy link
Contributor

slancio commented Apr 25, 2018

This makes sense to me!

Copy link
Contributor

@smashling smashling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mraible The information added is correct.

@mraible mraible merged commit efb8423 into oktadev:master Apr 26, 2018
AlainODea added a commit to AlainODea/okta-aws-cli-assume-role that referenced this pull request Jun 3, 2018
* 📝 Fill in config.properties documentation

 - Document OKTA_PROFILE

 - Document OKTA_BROWSER_AUTH

* 🎨 Clarify OKTA_PROFILE explanation
@AlainODea AlainODea deleted the ao-MEMO-add-missing-docs branch August 1, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants