Support new Vagrant commands #2787
Conversation
Vagrant 1.6 introduces a couple new commands, including the `version` command. The `version` command shows the currently installed version information and also checks for new updates available.
Vagrant 1.5 introduced Vagrant Share to allow remote access to a Vagrant environment. This adds support for the `share` and `connect` commands.
Vagrant 1.5 added Vagrant Cloud to share boxes. Some boxes may be protected, the `login` command allows to access those protected boxes from Vagrant Cloud.
Vagrant 1.6 introduced the `global-status` command which allows to get a quick overview of all active Vagrant environments for the currently logged in user.
|
Hi, and thanks for contributing. The vagrant plugin is in need of maintenance. Before submitting new features, maybe you could try to fix the currently existing issues — eg #2797. Also, if you want this PR to have a chance of being pulled, you should try to find vagrant plugin users to test your changes. |
|
Hi Nicolas, I think both are important, fixing existing issues, but also this one. Making an unrelated issue's fix a requirement doesn't sound very convincing. I can live with and get other user's feedback for this issue of course. If you look at the changes you see that the PR really just adds to the existing completions. Concerning #2797, yes that'd probably be nice but also a lot more complicated compared to this PR. I have run into a similar issue where no completion is offered past the first parameter and would like that to be working, too. I actually might go and try to implement that. However, as I said I see no relation between the two issues. |
|
I understand that your changes are simple, but even though it makes them easy to review, it does not exonerate them from being reviewed: you may have inadvertently duplicated an option, or made a typo...
Yes, it was not very well thought on my part to use the word "before", sorry about that. What I meant is that, since you seem willing to contribute to that plugin, there is more work just waiting for you to pick it up. ;-) |
| 'destroy:Destroys the vagrant environment' | ||
| 'global-status:Reports the status of all active Vagrant environments on the system.' |
There was a problem hiding this comment.
For the sake of consistency, you may want to remove the final dot on that line.
|
@ncanceill yes, that sounds a lot better ;) Definitely willing to contribute more if I can. Also no doubt that changes need reviews! Unfortunately I could not find a clear contribution workflow description for ohmyzsh |
This is a Work In Progress: #2766 (more like Future Work In Progress), but still 😄 |
|
@mcornella thanks for referencing that issue! |
|
works for me. |
|
@irnnr's changes looks fine to me |
|
Works! Thanks Ingo! 👍 |
|
👍 Work for me |
Support new Vagrant commands
|
thanks guys! |
Vagrant 1.5 and 1.6 added a couple new commands including
version,shareandconnect,login, andglobal-status. This PR adds these commands to zsh completion.