Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

fixed wrong endpoint #1236

Merged
merged 1 commit into from
Jan 16, 2020
Merged

fixed wrong endpoint #1236

merged 1 commit into from
Jan 16, 2020

Conversation

Spixmaster
Copy link
Contributor

I also wrote an Instagram API but in C++ which you can see as it is open source too. When copying the endpoints from other repositories I recognized that it seems to me that the concerned endpoint in this pull request seems to cause problems. In my case the Instagram servers returned an error. I think it was status code 301 with no response body but I cannot assure that but I think it was that.

I assume that you copied from mpg25/Instagram-API and he does the same: https://github.com/mgp25/Instagram-API/blob/master/src/Request/People.php (line 128)

I tried out ping's endpoint with query string which worked for me: https://github.com/ping/instagram_private_api/blob/0fda0369ac02bc03d56f5f3f99bc9de2cc25ffaa/instagram_private_api/endpoints/misc.py#L77

It is your decision: For me your and mpg25's solution did not work.

PS: How did you manage to get Instagram's endpoints?! It is such a torture to do that. I tried it for like 3 week with every possible solution I found on the Internet and nothing worked. I described what I did in my wiki if you are interested: https://github.com/Spixmaster/instagram-private-api/wiki

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6b0623a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1236   +/-   ##
========================================
  Coverage          ?   43.6%           
========================================
  Files             ?      32           
  Lines             ?    3580           
  Branches          ?     582           
========================================
  Hits              ?    1561           
  Misses            ?    1877           
  Partials          ?     142
Impacted Files Coverage Δ
instabot/api/api.py 50.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0623a...2a3d0eb. Read the comment docs.

@Spixmaster
Copy link
Contributor Author

Spixmaster commented Jan 16, 2020

In general, can forks be deleted after a successful merge?

@bruvv
Copy link
Collaborator

bruvv commented Jan 16, 2020

Yes and thanks will look into your pr asap

@bruvv
Copy link
Collaborator

bruvv commented Jan 16, 2020

First thing I noticed, you pulled against branch master. Can you do that to developement :) ?

@Spixmaster Spixmaster changed the base branch from master to development January 16, 2020 17:32
@Spixmaster
Copy link
Contributor Author

First thing I noticed, you pulled against branch master. Can you do that to developement :) ?

Done.

@bruvv bruvv self-assigned this Jan 16, 2020
@bruvv bruvv merged commit a122399 into ohld:development Jan 16, 2020
@bruvv
Copy link
Collaborator

bruvv commented Jan 16, 2020

Thanks, merged!

I agree on the endpoints, @ohld did rebase it a few months ago with some aditions from different source including his own. It is not my expertise part too so I cannot reply on that much. Last link you posted: https://plainsec.org/how-to-bypass-instagram-ssl-pinning-on-android-v78/

@Spixmaster
Copy link
Contributor Author

Thanks, merged!

I agree on the endpoints, @ohld did rebase it a few months ago with some aditions from different source including his own. It is not my expertise part too so I cannot reply on that much. Last link you posted: https://plainsec.org/how-to-bypass-instagram-ssl-pinning-on-android-v78/

Thank you very much first for your trust in me concerning the pull request and for the kind answer concerning sniffing Instagram's http requests. It is so awful to try it and so frustrating.

Unfortunately, I tried every method despite that blog post but now I will try it out.

Thank you very much. I appreciate the developing community very much. They helped me out so many times.

I tried the instagram api from ping, LevPasha and this is definitely the best one.

Have a nice day.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants