prov/opx: Add GDRCopy logging and failure path #10221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Huber <[email protected]>
|
Hoping this can still make it into 1.22... |
j-xiong
reviewed
Jul 25, 2024
|
|
||
| if (gdrcopy_enabled == 1) { | ||
| if (use_gdrcopy == 1) { | ||
| FI_WARN(&fi_opx_provider, FI_LOG_FABRIC, "GDRCopy has been requested and is available. If you wish to explicity disable GDRCopy, set FI_HMEM_CUDA_USE_GDRCOPY=0\n"); |
There was a problem hiding this comment.
Why produce a warning when the result is as expected?
| goto err; | ||
| } else { | ||
| /* gdrcopy_enabled = 0 and use_gdr = 0 */ | ||
| FI_WARN(&fi_opx_provider, FI_LOG_FABRIC, "If GDRCopy is installed on this system, change FI_HMEM_CUDA_USE_GDRCOPY=0 to FI_HMEM_CUDA_USE_GDRCOPY=1 to enable GDRCopy. \n"); |
There was a problem hiding this comment.
Same here, this path is only reached when gdrcopy is explicitly disabled.
|
BTW, this won't be able to get into 1.22.0. |
Ok, understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added messaging and some failures when GDRCopy is/is not being used and is/is not available.