Add "fw=no" as a proper mode #902
Labels
Comments
xmo-odoo
added a commit
that referenced
this issue
Jun 28, 2024
After seeing it be used, I foresee confusion around the current behaviour (where it sets the limit), as one would expect the `fw=` flags to affect one another when it looks like that would make sense e.g. no/default/skipci/skipmerge all specify how to forward port, so `fw=default` not doing anything after you've said `fw=no` (possibly by mistake) would be fucking weird. Also since the author can set limits, allow them to reset the fw policy to default (keep skipci for reviewers), and for @d-fence add a `fw=disabled` alias. Fixes #902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the documentation and seeing people use it (e.g. odoo/odoo#171165 (comment)) I think it's going to bite us (me) in the ass that
fw=noupdates the limit, because eventually people willfw=defaultassuming that revertsfw=no, and that's not going to work, and they're going to end up super confused.So fw=no should be a proper fw mode, and it should be handled separately from the limit. Setting the limit to the same branch would still work as before but would not be the normal way to prevent a forward port anymore.
The text was updated successfully, but these errors were encountered: