Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] events: revenues report #9953

Closed
wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

This BRAND NEW PR specifically focuses on the Revenues portion of the Reporting element in the Odoo Events application.

This doc will succinctly cover the basics of the Revenues Reporting page, the default settings, and how to create custom reports for unique analysis.

PROJECT TASK: https://www.odoo.com/odoo/3835/tasks/4012680?cids=3

@ksc-odoo ksc-odoo self-assigned this Jun 25, 2024
@robodoo
Copy link
Collaborator

robodoo commented Jun 25, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team June 25, 2024 18:46
@ksc-odoo ksc-odoo marked this pull request as draft June 25, 2024 18:47
@ksc-odoo ksc-odoo force-pushed the 17.0-events-revenues-reporting-ksc branch from a2e07ab to b599318 Compare June 26, 2024 16:37
@ksc-odoo ksc-odoo marked this pull request as ready for review June 26, 2024 16:38
@ksc-odoo ksc-odoo force-pushed the 17.0-events-revenues-reporting-ksc branch from b599318 to 3df6a3b Compare June 26, 2024 16:42
@ksc-odoo
Copy link
Contributor Author

Alrighty, @jero-odoo -- this one's ready for a Peer Review (whenever you get a chance). Thanks! 👍

@ksc-odoo ksc-odoo requested a review from jero-odoo June 26, 2024 16:54
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo great work! I just had a few notes and suggestions, but otherwise this is ready for the next round. Let me know if you have any questions, thanks!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-revenues-reporting-ksc branch 2 times, most recently from 972ed0b to 13acd92 Compare June 26, 2024 20:49
@ksc-odoo
Copy link
Contributor Author

Thanks for the super-helpful feedback, @jero-odoo -- I made those adjustments, and believe this PR is now ready for Final Review (@StraubCreative -- whenever you get a chance. Thanks!)

@larm-odoo larm-odoo self-requested a review July 9, 2024 21:24
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo - great doc! I learned a lot reading this, and the examples you gave are great and I think a value-add for the readers. Just a few comments, all optional (and some questions to consider).

content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
@StraubCreative StraubCreative removed their request for review July 10, 2024 21:24
@StraubCreative
Copy link
Contributor

@ksc-odoo to merge this in please address @larm-odoo feedback and pass to @samueljlieber after, thanks!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-revenues-reporting-ksc branch 3 times, most recently from c4a7a9c to 027cfaa Compare July 30, 2024 17:53
@ksc-odoo
Copy link
Contributor Author

Thank you for the helpful feedback, @larm-odoo -- I made those edits, and believe this one is now ready for Tech Review, @samueljlieber (whenever you get a chance). Thanks! 🙏

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Great job on this Events revenue reporting doc, everything looks good to me! I think you covered analyzing event revenue very well with these use cases. Approving with a couple quick fixes, thank you for your work!
.....
@robodoo delegate=ksc-odoo

content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
content/applications/marketing/events/revenues_report.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 17.0-events-revenues-reporting-ksc branch from 027cfaa to 4ba4f78 Compare July 30, 2024 20:13
@ksc-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo robodoo closed this in be0b5e6 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants