Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Essentials:  Export and Import #10293

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

Improvements to doc:https://www.odoo.com/documentation/17.0/applications/essentials/export_import_data.html

Adding section on updating data through export/import

Two corrections to "Import from another application" section

Docs task:https://www.odoo.com/mail/view?model=project.task&res_id=4059306&access_token=4e8385a9-be6e-4d98-b156-595a4d22a887

@jero-odoo jero-odoo self-assigned this Jul 22, 2024
@robodoo
Copy link
Collaborator

robodoo commented Jul 22, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 22, 2024 17:50
@jero-odoo
Copy link
Contributor Author

@larm-odoo this is ready for review. I added a section and made a slight change to another section, those are the only ones that need review at this time. Thanks!

@jero-odoo jero-odoo requested a review from larm-odoo July 22, 2024 17:58
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo - super short and informative updates, I just had two suggestions!

content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 17.0-essentials-export-import-jero branch from 054f0f6 to 2a7d758 Compare July 22, 2024 18:19
@jero-odoo
Copy link
Contributor Author

Hey @ksc-odoo this is ready for final review. I added a section and made a slight change to another section, those are the only ones that need review at this time. Thanks!

@jero-odoo jero-odoo requested a review from a team July 23, 2024 14:23
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- just finished my Final Review of this succinct PR. Nicely done. I do have a small collection of feedback/comments that require your attention. But, once you implement those necessary adjustments, you can feel free to move this one to Tech Review. Thanks! 👍

content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
content/applications/essentials/export_import_data.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 17.0-essentials-export-import-jero branch from c001111 to dca30fb Compare July 23, 2024 17:27
@jero-odoo
Copy link
Contributor Author

Thanks KC!
@StraubCreative this is ready for tech review. Thanks!

@jero-odoo jero-odoo requested a review from a team July 23, 2024 17:41
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! Nice work on this improvement to the export and import doc. I think you covered the feedback well. I have a couple suggestions to add internal references to where "updating data" was mentioned in the doc:

line 41:

   only shows the fields that can be imported. This is helpful in the case where the :ref:`existing
   records need to be updated <essentials/update-data>`. This works like a filter. Leaving the box
   unticked, gives many more field options because it shows all the fields, not just the ones that
   can be imported.

line 77:

be :ref:`updated in bulk <essentials/update-data>`. The following documentation covers how to import
data into an Odoo database.

line 176:

- :ref:`Update imports <essentials/update-data>`: import the same file several times without
  creating duplicates.

Thanks for your work!
..
@robodoo delegate=jero-odoo

Co-authored-by: larm-odoo <[email protected]>

Co-authored-by: ksc-odoo <[email protected]>

Co-authored-by: Sam Lieber (sali) <[email protected]>
@jero-odoo jero-odoo force-pushed the 17.0-essentials-export-import-jero branch from f2f7bcd to 408e699 Compare July 26, 2024 15:38
@jero-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Jul 26, 2024
closes #10293

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: larm-odoo <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: Sam Lieber (sali) <[email protected]>
@robodoo robodoo closed this in d2497d2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants