Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for General App Properties #245

Merged
merged 16 commits into from
Aug 1, 2022

Conversation

sanyud24
Copy link
Contributor

  • Added tests for ServerSettingsFragment, AdminConfiguration Fragment and tableSetting fragment for general settings
  • Added custom ViewAction and ViewMatcher methods.

@odk-x-bot
Copy link

Can one of the admins verify this patch? Also need an authorization to run tests.

@sanyud24
Copy link
Contributor Author

Hi @wbrunette for the Table-specific Settings, I'm not sure what changes were made after setting the "Use custom home screen checkbox as true",& also in the device setting fragment the text size or languages were not changed for the device.

@@ -138,6 +138,8 @@ dependencies {
implementation group: 'com.google.zxing', name: 'core', version: '3.3.0'
implementation group: 'com.journeyapps', name: 'zxing-android-embedded', version: '3.5.0'
implementation 'androidx.test:core:1.4.0'
implementation 'androidx.test.espresso:espresso-contrib:3.4.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a test dependency should it not be under testImplementation or androidTestImplementation instead of implementation? Also androidx.test:core should also probably be moved to one or both as implementation is for the actual code not test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry about that, I was getting the error of checker framework when using the dependency under android test implementation so I put that under implementation. Fixed it by excluding the checker group under android tests.

@sanyud24 sanyud24 requested a review from wbrunette July 22, 2022 11:36
@sanyud24
Copy link
Contributor Author

Hi, @wbrunette I've finished writing the test for "General app properties" and created an issue in the odk-forum for the doubt https://forum.odk-x.org/t/odk-x-services-ui-test-doubt/1839

@sanyud24 sanyud24 mentioned this pull request Jul 29, 2022
@wbrunette
Copy link
Member

@sanyud24 please fix merge conflicts

@sanyud24
Copy link
Contributor Author

@sanyud24 please fix merge conflicts

Fixed it @wbrunette

@wbrunette
Copy link
Member

@sanyud24 please fix merge conflicts

@wbrunette wbrunette merged commit 8eb1a3c into odk-x:outreachy-2022 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants